From a3ffe41935c3859e88f91b525dbd591c9b1fa1cb Mon Sep 17 00:00:00 2001 From: jhjang <jhjang@maprex.co.kr> Date: 일, 05 12월 2021 17:43:14 +0900 Subject: [PATCH] - api 수정시 이슈 상태만 수정 가능하도록 수정 --- src/main/java/kr/wisestone/owl/service/impl/IssueServiceImpl.java | 436 ++++++++++++++++++++++++++++++++++++++++++------------ 1 files changed, 337 insertions(+), 99 deletions(-) diff --git a/src/main/java/kr/wisestone/owl/service/impl/IssueServiceImpl.java b/src/main/java/kr/wisestone/owl/service/impl/IssueServiceImpl.java index 934520a..eb5524e 100644 --- a/src/main/java/kr/wisestone/owl/service/impl/IssueServiceImpl.java +++ b/src/main/java/kr/wisestone/owl/service/impl/IssueServiceImpl.java @@ -7,6 +7,7 @@ import kr.wisestone.owl.constant.ElasticSearchConstants; import kr.wisestone.owl.constant.MsgConstants; import kr.wisestone.owl.constant.UsePartner; +import kr.wisestone.owl.data.CheckIssueData; import kr.wisestone.owl.domain.*; import kr.wisestone.owl.domain.enumType.CustomFieldType; import kr.wisestone.owl.domain.enumType.EmailType; @@ -20,10 +21,7 @@ import kr.wisestone.owl.util.*; import kr.wisestone.owl.util.DateUtil; import kr.wisestone.owl.vo.*; -import kr.wisestone.owl.web.condition.IssueCondition; -import kr.wisestone.owl.web.condition.IssueCustomFieldValueCondition; -import kr.wisestone.owl.web.condition.IssueTypeCustomFieldCondition; -import kr.wisestone.owl.web.condition.ProjectCondition; +import kr.wisestone.owl.web.condition.*; import kr.wisestone.owl.web.form.*; import kr.wisestone.owl.web.view.ExcelView; import org.apache.commons.lang3.StringUtils; @@ -55,9 +53,6 @@ private IssueRepository issueRepository; @Autowired - private IssueTableConfigService issueTableConfigService; - - @Autowired private ProjectService projectService; @Autowired @@ -80,15 +75,6 @@ @Autowired private ApiTokenService apiTokenService; - - @Autowired - private CompanyFieldService companyFieldService; - - @Autowired - private IspFieldService ispFieldService; - - @Autowired - private HostingFieldService hostingFieldService; @Autowired private CommonConfiguration configuration; @@ -160,6 +146,9 @@ private UserWorkspaceService userWorkspaceService; @Autowired + private WorkflowDepartmentService workflowDepartmentService; + + @Autowired private IssueRelationService issueRelationService; @Autowired @@ -191,11 +180,7 @@ } - - // API 瑜� �넻�빐 �씠�뒋 異붽�. - @Override - @Transactional - public Issue addApiIssue(IssueApiForm issueApiForm) { + private IssueForm convertToIssueForm(IssueApiForm issueApiForm, User user) { if (issueApiForm.getIssueTypeId() == null) { throw new OwlRuntimeException(this.messageAccessor.getMessage(MsgConstants.API_PARAMETER_ISSUE_TYPE_ERROR)); } @@ -207,6 +192,28 @@ throw new OwlRuntimeException(this.messageAccessor.getMessage(MsgConstants.API_PARAMETER_ISSUE_TYPE_ERROR)); } + Workflow workflow = issueType.getWorkflow(); + + // �씠�뒋 �긽�깭媛� 吏��젙�릺�뼱 �엳吏� �븡�쓣 寃쎌슦 珥덇린媛믪쑝濡� 吏��젙 + if (issueApiForm.getIssueStatusId() == null) { + List<IssueStatusVo> issueStatusVos = issueStatusService.findByWorkflowId(workflow.getId()); + IssueStatusVo issueStatusVo = issueStatusVos.get(0); + issueApiForm.setIssueStatusId(issueStatusVo.getId()); + } + + // �썙�겕�뵆濡쒖슦 �긽�깭�뿉 �뵲瑜� �떞�떦遺��꽌 媛��졇�삤湲� + if (issueApiForm.getIssueStatusId() != null) { + WorkflowDepartmentCondition workflowDepartmentCondition = new WorkflowDepartmentCondition(); + workflowDepartmentCondition.setIssueStatusId(issueApiForm.getIssueStatusId()); + workflowDepartmentCondition.setWorkflowId(workflow.getId()); + List<WorkflowDepartmentVo> workflowDepartmentVos = this.workflowDepartmentService.find(workflowDepartmentCondition); + + for (WorkflowDepartmentVo workflowDepartmentVo : workflowDepartmentVos) { + issueForm.addDepartmentId(workflowDepartmentVo.getDepartmentVo().getId()); + } + } + + // �봽濡쒖젥�듃 �엯�젰 Project project = issueType.getProject(); if (project == null){ @@ -214,14 +221,7 @@ } issueForm.setProjectId(project.getId()); - // �넗�겙�쑝濡� �쑀�� �젙蹂� 媛��졇�삤湲� - String token = issueApiForm.getToken(); - UserVo userVo = this.apiTokenService.certification(token); - - // �빐�떦 �쑀�� �젙蹂닿� �쁽�옱 db�뿉 �엳�뒗吏� �솗�씤 - User user = this.userService.getUser(userVo.getId()); if (user != null) { - // 湲곕낯媛� �엯�젰�븯湲� IssueApiDefaultForm issueApiDefaultForm = new IssueApiDefaultForm(); issueApiDefaultForm.setUserId(user.getId()); @@ -229,6 +229,7 @@ IssueApiDefault issueApiDefault = this.issueApiDefaultService.find(issueApiDefaultForm); if (issueApiDefault != null) { ConvertUtil.copyProperties(issueApiDefault, issueForm); + issueForm.setId(null); issueForm.setPriorityId(issueApiDefault.getPriority().getId()); issueForm.setSeverityId(issueApiDefault.getSeverity().getId()); } @@ -251,11 +252,33 @@ // api �엯�젰媛� �쟻�슜 ConvertUtil.copyProperties(issueApiForm, issueForm); - return addIssue(user, issueForm, issueApiForm.getMultipartFiles()); + return issueForm; + } else { throw new OwlRuntimeException(this.messageAccessor.getMessage(MsgConstants.API_USER_ERROR)); } } + + private User convertToUser(String token) { + // �넗�겙�쑝濡� �쑀�� �젙蹂� 媛��졇�삤湲� + UserVo userVo = this.apiTokenService.certification(token); + + // �빐�떦 �쑀�� �젙蹂닿� �쁽�옱 db�뿉 �엳�뒗吏� �솗�씤 + return this.userService.getUser(userVo.getId()); + } + + + // API 瑜� �넻�빐 �씠�뒋 異붽�. + @Override + @Transactional + public Issue addApiIssue(IssueApiForm issueApiForm) { + User user = convertToUser(issueApiForm.getToken()); + IssueForm issueForm = this.convertToIssueForm(issueApiForm, user); + + return addIssue(user, issueForm, issueApiForm.getMultipartFiles()); + } + + // 以묐났�맂 �긽�쐞 �씠�뒋 寃��깋 private IssueVo findIssue(IssueApiForm issueApiForm, Long userId) { @@ -319,6 +342,10 @@ issue.setIssueType(issueType); issue.setPriority(priority); issue.setSeverity(severity); + if (issueForm.getParentIssueId() != null){ + Issue parentIssue = this.getIssue(issueForm.getParentIssueId()); + issue.setParentIssue(parentIssue); + } issue.setIssueNumber(this.issueNumberGeneratorService.generateIssueNumber(project)); // 媛� �봽濡쒖젥�듃�쓽 怨좎쑀 �씠�뒋 踰덊샇 �깮�꽦 @@ -328,7 +355,7 @@ // �떞�떦�옄 吏��젙 //this.issueUserService.modifyIssueUser(issue, project.getWorkspace(), issueForm.getUserIds()); // �떞�떦遺��꽌 吏��젙 - this.issueDepartmentService.modifyIssueDepartment(issue, project.getWorkspace(), issueForm.getDepartmentIds()); + this.issueDepartmentService.modifyIssueDepartment(issue, user, project.getWorkspace(), issueForm.getDepartmentIds()); // �뾽泥� �젙蹂� ���옣 this.issueCompanyService.modifyIssueCompanyField(issue, issueForm.getIssueCompanyFields()); // ISP �젙蹂� ���옣 @@ -373,7 +400,6 @@ projectRoleUserMap.put("statuses", Lists.newArrayList("02")); // 愿�由ъ옄 議고쉶 // 愿�由ъ옄 �젙蹂� �뀑�똿 List<Map<String, Object>> projectRoleUsers = this.projectRoleUserService.findProjectRoleUser(projectRoleUserMap); - if (projectRoleUsers != null && !projectRoleUsers.isEmpty()) { for (Map<String, Object> projectRoleUser : projectRoleUsers) { UserVo userVo = ConvertUtil.convertMapToClass(projectRoleUser, UserVo.class); @@ -407,7 +433,7 @@ departsBuilder.append(issueDepartment.getDepartment().getDepartmentName()); departsBuilder.append("\n"); } - issueMap.put("departsBuilder", departsBuilder.toString()); + issueMap.put("departments", departsBuilder.toString()); // 湲곌컙 if (!StringUtils.isEmpty(issue.getStartDate())) { @@ -556,7 +582,10 @@ // �씠�뒋 �븘�씠�뵒 珥덇린�솕 issueCondition.setIssueIds(Lists.newArrayList()); // Map �뿉 �엳�뒗 �뜲�씠�꽣瑜� IssueVo �뜲�씠�꽣濡� 蹂��솚�븳�떎. - this.setMapToIssueVo(results, issueVos, issueCondition); + User user = this.webAppUtil.getLoginUserObject(); + this.setMapToIssueVo(results, issueVos, issueCondition, user); + + this.setCountDownIssues(results, issueVos); resJsonData.put(Constants.RES_KEY_CONTENTS, issueVos); resJsonData.put(Constants.REQ_KEY_PAGE_VO, new ResPage(pageable.getPageNumber(), pageable.getPageSize(), @@ -566,6 +595,77 @@ log.info(ElasticSearchUtil.makeUserActiveHistoryMessage(this.webAppUtil.getLoginUser(), ElasticSearchConstants.ISSUE_FIND)); return issueVos; } + + private void setCountDownIssues(List<Map<String, Object>> results, List<IssueVo> issueVos) { + for (Map<String, Object> result : results){ + List<Issue> downIssues = this.issueRepository.findByParentIssueId((Long) result.get("id")); //�븯�쐞�씠�뒋 媛��졇�삤湲� + if(downIssues != null && downIssues.size() > 0){ //�긽�쐞�씠�뒋 媛�吏�怨� �엳�뒗 �븷�뱾�씠 �엳�쑝硫� + int downIssueCount = 0; + for(Issue downIssue : downIssues){ + downIssueCount ++; + Long parentIssueId = downIssue.getParentIssue().getId(); + Issue parentIssue = this.getIssue(parentIssueId); + IssueVo parentIssueVo = ConvertUtil.copyProperties(parentIssue, IssueVo.class); + parentIssueVo.setDownIssueCount(downIssueCount); + + for(IssueVo issueVo : issueVos){ + if(issueVo.getId().equals(parentIssueVo.getId())){ + issueVo.setDownIssueCount(parentIssueVo.getDownIssueCount()); + } + } + } + } + } + } + + + // �씠�뒋 紐⑸줉�쓣 議고쉶�븳�떎(李⑦듃�슜 - �뿰愿��씪媛먰룷�븿) + @Override + @Transactional(readOnly = true) + public void findApiIssue(ApiMonitorCondition apiMonitorCondition, Map<String, Object> resJsonData) { + + IssueTypeCondition issueTypeCondition = new IssueTypeCondition(); + List<IssueTypeVo> issueTypes = this.issueTypeService.findIssueType(issueTypeCondition); + + // 媛믪씠 �뾾�쓣 寃쎌슦 珥덇린媛� �엯�젰 + if (StringUtils.isEmpty(apiMonitorCondition.getSearchPeriod())) { + apiMonitorCondition.setSearchPeriod(DateUtil.LAST_SEVEN_DAYS); + } + + // 寃��깋 �씪�옄瑜� 援ы븳�떎. + List<Date> searchDates = CommonUtil.findSearchPeriod(apiMonitorCondition.getSearchPeriod()); + + // �궇吏쒓� 寃��깋�릺吏� �븡�븯�쑝硫� �삤瑜� + if (searchDates.size() < 1) { + throw new OwlRuntimeException( + this.messageAccessor.getMessage(MsgConstants.WIDGET_SEARCH_DATE_NOT_FOUND)); + } + + Long index = 1L; + List<ApiMonitorVo> apiMonitorVos = Lists.newArrayList(); + for (Date date : searchDates) { + + String onlyDate = DateUtil.convertDateToYYYYMMDD(date); + issueTypeCondition.setStartDate(onlyDate + " 00:00:00"); + issueTypeCondition.setEndDate(onlyDate + " 23:59:59"); + + ApiMonitorVo apiMonitorVo = new ApiMonitorVo(); + apiMonitorVo.setId(index); + for (IssueTypeVo issueTypeVo : issueTypes) { + issueTypeCondition.setId(issueTypeVo.getId()); + apiMonitorVo.addIssueTypeCount(this.issueMapper.countByIssueTypeIdAndDate(issueTypeCondition)); + apiMonitorVo.setIsApi(Issue.IS_API_YES); + + apiMonitorVos.add(apiMonitorVo); + } + index++; + } + Map<String, Object> data = new HashMap<>(); + data.put("issueTypeVos", issueTypes); + data.put("apiMonitorVos", apiMonitorVos); + resJsonData.put(Constants.RES_KEY_CONTENTS, data); + } + // �씠�뒋 紐⑸줉�쓣 議고쉶�븳�떎(李⑦듃�슜 - �뿰愿��씪媛먰룷�븿) @Override @@ -622,7 +722,9 @@ IssueCondition issueCondition = new IssueCondition(); // 寃��깋 議곌굔�쓣 留뚮뱺�떎 - if (!this.makeIssueSearchCondition(issueCondition, projectCondition, pageable)) { + + User user = this.webAppUtil.getLoginUserObject(); + if (!this.makeIssueSearchCondition(user, issueCondition, projectCondition, pageable)) { // �씠�뒋 紐⑸줉�쓣 李얠� 紐삵븷 寃쎌슦 湲곕낯 �젙蹂대줈 由ы꽩�븳�떎. this.notFoundIssueList(resJsonData, pageable); return Lists.newArrayList(); @@ -666,7 +768,7 @@ } // Map �뿉 �엳�뒗 �뜲�씠�꽣瑜� IssueVo �뜲�씠�꽣濡� 蹂��솚�븳�떎. - private void setMapToIssueVo(List<Map<String, Object>> results, List<IssueVo> issueVos, IssueCondition issueCondition) { + private void setMapToIssueVo(List<Map<String, Object>> results, List<IssueVo> issueVos, IssueCondition issueCondition, User user) { for (Map<String, Object> result : results) { IssueVo issueVo = ConvertUtil.convertMapToClass(result, IssueVo.class); issueVos.add(issueVo); @@ -675,7 +777,7 @@ // �씠�뒋 �궗�슜�옄 �젙蹂� 異붽� //this.setIssueUserList(issueVos, issueCondition); - this.setIssueDepartmentList(issueVos, issueCondition); + this.setIssueDepartmentList(issueVos, issueCondition, user); // �벑濡앹옄 �젙蹂� 異붽� this.setRegister(issueVos); // �떞�떦�옄 �젙蹂� �뀑�똿 @@ -722,7 +824,7 @@ } // 寃��깋 議곌굔�쓣 留뚮뱺�떎 - private boolean makeIssueSearchCondition(IssueCondition condition, ProjectCondition projectCondition, Pageable pageable) { + private boolean makeIssueSearchCondition(User user, IssueCondition condition, ProjectCondition projectCondition, Pageable pageable) { if (pageable != null) { condition.setPage(pageable.getPageNumber() * pageable.getPageSize()); condition.setPageSize(pageable.getPageSize()); @@ -740,7 +842,7 @@ // �봽濡쒖젥�듃瑜� �꽑�깮�븯吏� �븡�븯�쑝硫� �빐�떦 �뾽臾� 怨듦컙�뿉�꽌 李몄뿬�븯怨� �엳�뒗 �봽濡쒖젥�듃瑜� 李얜뒗�떎. if (condition.getProjectIds().size() < 1) { List<Map<String, Object>> projects = null; - if (this.userWorkspaceService.checkWorkspaceManager()) { + if (this.userWorkspaceService.checkWorkspaceManager(user)) { projects = this.projectMapper.findByWorkspaceManagerAll(projectCondition); } else { projects = this.projectService.findByWorkspaceIdAndIncludeProjectAll(projectCondition); @@ -818,7 +920,7 @@ } // �씠�뒋 �떞�떦�옄 �젙蹂대�� �뀑�똿�븳�떎. - private void setIssueUserList(List<IssueVo> issueVos, IssueCondition issueCondition) { + private void setIssueUserList(List<IssueVo> issueVos, IssueCondition issueCondition, User user) { if (issueVos.size() < 1) { return; } @@ -849,14 +951,14 @@ } // �씠�뒋 �닔�젙 沅뚰븳�쓣 媛뽮퀬 �엳�뒗吏� �솗�씤 - if (this.checkHasPermission(issueVo, issueVo.getUserVos())) { + if (this.checkHasPermission(issueVo, issueVo.getUserVos(), user)) { issueVo.setModifyPermissionCheck(Boolean.TRUE); } } } // �씠�뒋 �떞�떦遺��꽌 �젙蹂대�� �뀑�똿�븳�떎. - private void setIssueDepartmentList(List<IssueVo> issueVos, IssueCondition issueCondition) { + private void setIssueDepartmentList(List<IssueVo> issueVos, IssueCondition issueCondition, User user) { if (issueVos.size() < 1) { return; } @@ -886,7 +988,7 @@ } // �씠�뒋 �닔�젙 沅뚰븳�쓣 媛뽮퀬 �엳�뒗吏� �솗�씤 - if (this.checkHasPermission(issueVo, issueVo.getUserVos())) { + if (this.checkHasPermission(issueVo, issueVo.getUserVos(), user)) { issueVo.setModifyPermissionCheck(Boolean.TRUE); } } @@ -936,12 +1038,27 @@ // �븯�쐞 �씠�뒋 �젙蹂대�� �뀑�똿�븳�떎 private void setDownIssues(Issue issue, IssueVo issueVo) { List<Issue> downIssues = this.issueRepository.findByParentIssueId(issue.getId()); + /*if(issueVo != null && downIssues.size()>0){ + for(Issue downIssue : downIssues){ + IssueVo downIssueVo = ConvertUtil.copyProperties(downIssue, IssueVo.class); + IssueDownVo issueDownVo = ConvertUtil.copyProperties(downIssueVo, IssueDownVo.class); + issueDownVo.setIssueDown(downIssueVo); + issueDownVo.setTitle(downIssue.getTitle()); + issueDownVo.setIssueTypeVo(ConvertUtil.copyProperties(downIssue.getIssueType(), IssueTypeVo.class)); + issueDownVo.setPriorityVo(ConvertUtil.copyProperties(downIssue.getPriority(), PriorityVo.class)); + issueDownVo.setSeverityVo(ConvertUtil.copyProperties(downIssue.getSeverity(), SeverityVo.class)); + this.setRegister(downIssue, downIssueVo); // �벑濡앹옄 + this.setIssueDepartment(downIssue, downIssueVo); // �떞�떦遺��꽌 �젙蹂� �뀑�똿 + this.setIssueCustomFields(downIssue, downIssueVo); // �궗�슜�옄�젙�쓽�븘�뱶 �젙蹂� �꽭�똿 + issueVo.addIssueDownVo(issueDownVo); + } + }*/ + List<IssueVo> downIssueVos = ConvertUtil.convertObjectsToClasses(downIssues, IssueVo.class); List<IssueVo> resultList = new ArrayList<>(); - if(downIssues != null && downIssueVos.size()>0){ + if(downIssueVos != null && downIssueVos.size()>0){ for(IssueVo downIssueVo : downIssueVos){ for(Issue downIssue : downIssues){ - downIssueVo.setTitle(downIssue.getTitle()); downIssueVo.setIssueTypeVo(ConvertUtil.copyProperties(downIssue.getIssueType(), IssueTypeVo.class)); downIssueVo.setPriorityVo(ConvertUtil.copyProperties(downIssue.getPriority(), PriorityVo.class)); downIssueVo.setSeverityVo(ConvertUtil.copyProperties(downIssue.getSeverity(), SeverityVo.class)); @@ -951,9 +1068,7 @@ } resultList.add(downIssueVo); } - issueVo.setIssueDownVos(resultList); //�봽濡좏듃�뿉�꽌 List�삎�깭濡� 諛쏆븘以섏꽌 由ъ뒪�듃 �삎�떇�쑝濡� 蹂대궡以� - }else{ - issueVo.setIssueDownVos(null); + issueVo.setIssueDownVos(resultList); } } @@ -1141,14 +1256,62 @@ issueVo.setIssueHistoryVos(this.issueHistoryService.findIssueHistory(issue.getId())); } + // �궗�슜�옄 �젙�쓽 �븘�뱶 媛믪씠 媛숈� �씠�뒋 李얘린 + @Override + @Transactional + public List<IssueVo> findIssue(IssueApiForm issueApiform) { + List<IssueCustomFieldValueForm> issueCustomFieldValueForms = issueApiform.getIssueCustomFieldValues(); + IssueCustomFieldValueCondition issueCustomFieldValueCondition = new IssueCustomFieldValueCondition(); + if (issueCustomFieldValueForms != null && issueCustomFieldValueForms.size() > 0) { + for (IssueCustomFieldValueForm issueCustomFieldValueForm : issueCustomFieldValueForms) { + issueCustomFieldValueCondition.addUseValues(issueCustomFieldValueForm.getUseValue()); + } + } + List<Map<String, Object>> results = this.issueMapper.findByCustomFieldValue(issueCustomFieldValueCondition); + List<IssueVo> issueVos = Lists.newArrayList(); + if (results != null && results.size() > 0) { + issueVos.add(ConvertUtil.convertMapToClass(results.get(0), IssueVo.class)); + } + + return issueVos; + } + + + // �씠�뒋瑜� �닔�젙�븳�떎(api�슜) + @Override + @Transactional + public List<Issue> modifyIssue(IssueApiForm issueApiForm, List<MultipartFile> files) { + User user = this.convertToUser(issueApiForm.getToken()); + IssueForm issueForm = this.convertToIssueForm(issueApiForm, user); + + List<IssueVo> issueVos = this.findIssue(issueApiForm); + List<Issue> issue = Lists.newArrayList(); + for (IssueVo issueVo : issueVos) { + issueForm.setId(issueVo.getId()); + issue.add(this.modifyIssueForApi(user, issueForm, files)); + } + + return issue; + } + // �씠�뒋瑜� �닔�젙�븳�떎. @Override @Transactional public Issue modifyIssue(IssueForm issueForm, List<MultipartFile> multipartFiles) { + User user = this.webAppUtil.getLoginUserObject(); + return modifyIssue(user, issueForm, multipartFiles); + } + + // �닔�젙 �뜲�씠�꽣媛� �쑀�슚�븳吏� �솗�씤 + private CheckIssueData checkIssue(User user, IssueForm issueForm) { + // �궗�슜�븯怨� �엳�뒗 �뾽臾� 怨듦컙�씠 �솢�꽦 �긽�깭�씤吏� �솗�씤�븳�떎. �궗�슜 怨듦컙�뿉�꽌 濡쒓렇�씤�븳 �궗�슜�옄媛� 鍮꾪솢�꽦�씤吏� �솗�씤�븳�떎. - this.workspaceService.checkUseWorkspace(); + this.workspaceService.checkUseWorkspace(user, user.getLastWorkspaceId()); + + Issue issue = this.getIssue(issueForm.getId()); + IssueStatus oldIssueStatus = issue.getIssueStatus(); // �씠�뒋 �닔�젙 沅뚰븳 泥댄겕 - this.verifyIssueModifyPermission(issueForm.getId()); + this.verifyIssueModifyPermission(issue, user); // �봽濡쒖젥�듃 �쑀�슚�꽦 泥댄겕 Project project = this.projectService.getProject(issueForm.getProjectId()); // �씠�뒋 �긽�깭 �쑀�슚�꽦 泥댄겕 @@ -1169,10 +1332,83 @@ // �떞�떦遺��꽌 �쑀�슚�꽦 泥댄겕 this.verifyIssueDepartment(project, issueForm); - Issue issue = this.getIssue(issueForm.getId()); + CheckIssueData checkIssueData = new CheckIssueData(); + checkIssueData.setIssue(issue); + checkIssueData.setProject(project); + checkIssueData.setOldIssueStatus(oldIssueStatus); + checkIssueData.setNewIssueStatus(issueStatus); + checkIssueData.setIssueType(issueType); + checkIssueData.setPriority(priority); + checkIssueData.setSeverity(severity); + + return checkIssueData; + } + + // �씠�뒋 �닔�젙(API�슜) + private Issue modifyIssueForApi(User user, IssueForm issueForm, List<MultipartFile> multipartFiles) { + CheckIssueData checkIssueData = this.checkIssue(user, issueForm); + + Issue issue = checkIssueData.getIssue(); + Project project = checkIssueData.getProject(); + IssueType issueType = checkIssueData.getIssueType(); + IssueStatus oldIssueStatus = checkIssueData.getOldIssueStatus(); + IssueStatus issueStatus = checkIssueData.getNewIssueStatus(); // 蹂�寃� �씠�젰 �젙蹂� 異붿텧 - StringBuilder detectIssueChange = this.issueHistoryService.detectIssueChange(issue, issueForm, project, issueStatus, issueType, priority, severity, multipartFiles); + StringBuilder detectIssueChange = this.issueHistoryService.detectIssueChange(issueForm, checkIssueData, multipartFiles); + + // �봽濡쒖젥�듃媛� 蹂�寃쎈릺硫� �씠�뒋 �꽆踰꾨�� �깉濡� �뵲�빞 �븳�떎. + this.checkChangeProject(checkIssueData.getProject(), issue); + + // �씠�뒋 �쑀�삎�씠 蹂�寃쎈릺�뿀�뒗吏� �솗�씤�븯怨� 蹂�寃쎈릺�뿀�떎硫� �씠�뒋 �긽�깭 �냽�꽦�씠 '��湲�' �씤 �씠�뒋 �긽�깭濡� 援먯껜�븳�떎. + if (this.checkChangeIssueType(issueType, issueStatus, issue)) { + issueStatus = this.issueStatusService.findByIssueStatusTypeIsReady(issueType.getWorkflow()); + // �씠�뒋 �긽�깭 蹂�寃� �씠�젰 �궓湲곌린 - �씠�젰�쓣 �궓湲곌린 �쐞�빐 issueForm �뿉 issueStatus Id 媛믪쓣 ���옣. + issueForm.setIssueStatusId(issueStatus.getId()); + this.issueHistoryService.detectIssueStatus(issue, issueForm, detectIssueChange, oldIssueStatus, issueStatus); + } + + issue = this.saveIssue(issueForm, checkIssueData); + + // �씠�뒋 �씠�젰 �벑濡� + if (!StringUtils.isEmpty(detectIssueChange.toString())) { + this.issueHistoryService.addIssueHistory(issue, user, IssueHistoryType.MODIFY, detectIssueChange.toString()); + } + // �궗�슜�옄 �떆�뒪�뀥 湲곕뒫 �궗�슜 �젙蹂� �닔吏� + UserVo userVo = ConvertUtil.copyProperties(user, UserVo.class); + log.info(ElasticSearchUtil.makeUserActiveHistoryMessage(userVo, ElasticSearchConstants.ISSUE_MODIFY)); + + return issue; + } + + private Issue saveIssue(IssueForm issueForm, CheckIssueData checkIssueData) { + Issue issue = checkIssueData.getIssue(); + ConvertUtil.copyProperties(issueForm, issue, "id"); + issue.setProject(checkIssueData.getProject()); + issue.setIssueStatus(checkIssueData.getNewIssueStatus()); + issue.setIssueType(checkIssueData.getIssueType()); + issue.setPriority(checkIssueData.getPriority()); + issue.setSeverity(checkIssueData.getSeverity()); + issue.setStartDate(issueForm.getStartDate()); + issue.setCompleteDate(issueForm.getCompleteDate()); + + return this.issueRepository.saveAndFlush(issue); + } + + // �씠�뒋瑜� �닔�젙�븳�떎. + @Override + @Transactional + public Issue modifyIssue(User user, IssueForm issueForm, List<MultipartFile> multipartFiles) { + CheckIssueData checkIssueData = this.checkIssue(user, issueForm); + + Issue issue = checkIssueData.getIssue(); + IssueStatus oldIssueStatus = checkIssueData.getOldIssueStatus(); + Project project = checkIssueData.getProject(); + IssueStatus issueStatus = checkIssueData.getNewIssueStatus(); + IssueType issueType = checkIssueData.getIssueType(); + + // 蹂�寃� �씠�젰 �젙蹂� 異붿텧 + StringBuilder detectIssueChange = this.issueHistoryService.detectIssueChange(issueForm, checkIssueData, multipartFiles); // �봽濡쒖젥�듃媛� 蹂�寃쎈릺硫� �씠�뒋 �꽆踰꾨�� �깉濡� �뵲�빞 �븳�떎. this.checkChangeProject(project, issue); @@ -1182,30 +1418,21 @@ issueStatus = this.issueStatusService.findByIssueStatusTypeIsReady(issueType.getWorkflow()); // �씠�뒋 �긽�깭 蹂�寃� �씠�젰 �궓湲곌린 - �씠�젰�쓣 �궓湲곌린 �쐞�빐 issueForm �뿉 issueStatus Id 媛믪쓣 ���옣. issueForm.setIssueStatusId(issueStatus.getId()); - this.issueHistoryService.detectIssueStatus(issue, issueForm, detectIssueChange, issueStatus); + this.issueHistoryService.detectIssueStatus(issue, issueForm, detectIssueChange, oldIssueStatus, issueStatus); } - ConvertUtil.copyProperties(issueForm, issue, "id"); - issue.setProject(project); - issue.setIssueStatus(issueStatus); - issue.setIssueType(issueType); - issue.setPriority(priority); - issue.setSeverity(severity); - issue.setStartDate(issueForm.getStartDate()); - issue.setCompleteDate(issueForm.getCompleteDate()); - - this.issueRepository.saveAndFlush(issue); + issue = this.saveIssue(issueForm, checkIssueData); //this.issueUserService.modifyIssueUser(issue, project.getWorkspace(), issueForm.getUserIds()); // �떞�떦遺��꽌 吏��젙 if(issueForm.getDepartmentIds().size()>0){ - this.issueDepartmentService.modifyIssueDepartment(issue, project.getWorkspace(), issueForm.getDepartmentIds()); + this.issueDepartmentService.modifyIssueDepartment(issue, user, project.getWorkspace(), issueForm.getDepartmentIds()); } // multipartFile �쓣 file Map List 媛앹껜濡� 蹂�寃쏀븳�떎. List<Map<String, Object>> convertFileMaps = this.convertMultipartFileToFile(multipartFiles); // 泥⑤� �뙆�씪 ���옣 - 鍮꾨룞湲곕줈 �옉�룞 - this.attachedFileService.addAttachedFile(convertFileMaps, issue, this.webAppUtil.getLoginUser().getAccount()); + this.attachedFileService.addAttachedFile(convertFileMaps, issue, user.getAccount()); // �궘�젣�맂 泥⑤��뙆�씪 泥섎━ this.attachedFileService.removeAttachedFiles(issueForm.getRemoveFiles()); // �뀓�뒪�듃 �뿉�뵒�꽣�뿉 泥⑤��븳 �뙆�씪�쓣 �씠�뒋�� �뿰寃� @@ -1214,10 +1441,11 @@ this.issueCustomFieldValueService.modifyIssueCustomFieldValue(issue, issueForm.getIssueCustomFields()); // �씠�뒋 �씠�젰 �벑濡� if (!StringUtils.isEmpty(detectIssueChange.toString())) { - this.issueHistoryService.addIssueHistory(issue, IssueHistoryType.MODIFY, detectIssueChange.toString()); + this.issueHistoryService.addIssueHistory(issue, user, IssueHistoryType.MODIFY, detectIssueChange.toString()); } // �궗�슜�옄 �떆�뒪�뀥 湲곕뒫 �궗�슜 �젙蹂� �닔吏� - log.info(ElasticSearchUtil.makeUserActiveHistoryMessage(this.webAppUtil.getLoginUser(), ElasticSearchConstants.ISSUE_MODIFY)); + UserVo userVo = ConvertUtil.copyProperties(user, UserVo.class); + log.info(ElasticSearchUtil.makeUserActiveHistoryMessage(userVo, ElasticSearchConstants.ISSUE_MODIFY)); // �뾽泥� �젙蹂� ���옣 this.issueCompanyService.modifyIssueCompanyField(issue, issueForm.getIssueCompanyFields()); @@ -1339,11 +1567,9 @@ } // �씠�뒋 �닔�젙 沅뚰븳 泥댄겕 - private void verifyIssueModifyPermission(Long issueId) { - Issue issue = this.getIssue(issueId); - + private void verifyIssueModifyPermission(Issue issue, User user) { // �씠�뒋 �닔�젙 沅뚰븳�쓣 媛뽮퀬 �엳�뒗吏� �솗�씤 - if (!this.checkHasPermission(ConvertUtil.copyProperties(issue, IssueVo.class), this.getIssueUserVos(issue))) { + if (!this.checkHasPermission(ConvertUtil.copyProperties(issue, IssueVo.class), this.getIssueUserVos(issue), user)) { throw new OwlRuntimeException( this.messageAccessor.getMessage(MsgConstants.ISSUE_NOT_MODIFY_PERMISSION)); } @@ -1353,24 +1579,31 @@ private List<UserVo> getIssueUserVos(Issue issue) { List<UserVo> userVos = Lists.newArrayList(); - for (IssueUser issueUser : issue.getIssueUsers()) { - UserVo userVo = ConvertUtil.copyProperties(issueUser.getUser(), UserVo.class, "password"); - userVos.add(userVo); + Set<IssueUser> issueUsers = issue.getIssueUsers(); + + try { + for (IssueUser issueUser : issueUsers) { + User user = issueUser.getUser(); + UserVo userVo = ConvertUtil.copyProperties(user, UserVo.class, "password"); + userVos.add(userVo); + } + } catch (Exception ex) { + } return userVos; } // �씠�뒋 �닔�젙 沅뚰븳�쓣 媛뽮퀬 �엳�뒗吏� �솗�씤 - private boolean checkHasPermission(IssueVo issueVo, List<UserVo> issueUserVos) { + private boolean checkHasPermission(IssueVo issueVo, List<UserVo> issueUserVos, User user) { boolean hasPermission = false; // �뾽臾� 怨듦컙 愿�由ъ옄�씪 寃쎌슦 �닔�젙 沅뚰븳�쓣 媛뽯뒗�떎. - hasPermission = this.checkIssueModifyPermission(hasPermission, Issue.WORKSPACE_MANAGER, issueVo, null, null); + hasPermission = this.checkIssueModifyPermission(hasPermission, Issue.WORKSPACE_MANAGER, issueVo, null, null, user); // �봽濡쒖젥�듃 愿�由ъ옄�씪 寃쎌슦 �빐�떦 �봽濡쒖젥�듃�뿉 �벑濡앸맂 �씠�뒋�뒗 �닔�젙 沅뚰븳�쓣 媛뽯뒗�떎. - hasPermission = this.checkIssueModifyPermission(hasPermission, Issue.PROJECT_MANAGER, issueVo, null, null); + hasPermission = this.checkIssueModifyPermission(hasPermission, Issue.PROJECT_MANAGER, issueVo, null, null, user); // �씠�뒋 �벑濡앹옄�씪 寃쎌슦 �닔�젙 沅뚰븳�쓣 媛뽯뒗�떎. - hasPermission = this.checkIssueModifyPermission(hasPermission, Issue.REGISTER, issueVo, null, null); + hasPermission = this.checkIssueModifyPermission(hasPermission, Issue.REGISTER, issueVo, null, null, user); // �씠�뒋 �떞�떦�옄�씪 寃쎌슦 �닔�젙 沅뚰븳�쓣 媛뽯뒗�떎. => �떞�떦遺��꽌濡� �닔�젙 - 泥댄겕 //hasPermission = this.checkIssueModifyPermission(hasPermission, Issue.ASSIGNEE, issueVo, issueUserVos); // �떞�떦�옄媛� �뾾�쑝硫� 紐⑤뱺 �궗�슜�옄媛� �닔�젙 沅뚰븳�쓣 媛뽯뒗�떎. @@ -1379,22 +1612,22 @@ } // �씠�뒋 �닔�젙 沅뚰븳�쓣 �솗�씤�븳�떎. - private boolean checkIssueModifyPermission(Boolean hasPermission, String checkType, IssueVo issueVo, List<UserVo> issueUserVos, List<DepartmentVo> issueDepartmentVos) { + private boolean checkIssueModifyPermission(Boolean hasPermission, String checkType, IssueVo issueVo, List<UserVo> issueUserVos, List<DepartmentVo> issueDepartmentVos, User user) { if (!hasPermission) { switch (checkType) { case Issue.WORKSPACE_MANAGER: // �뾽臾� 怨듦컙 愿�由ъ옄 // �뾽臾� 怨듦컙 愿�由ъ옄�씪 寃쎌슦 �닔�젙 沅뚰븳�쓣 媛뽯뒗�떎. - hasPermission = this.userWorkspaceService.checkWorkspaceManager(); + hasPermission = this.userWorkspaceService.checkWorkspaceManager(user); break; case Issue.PROJECT_MANAGER: // �봽濡쒖젥�듃 愿�由ъ옄 Issue issue = this.getIssue(issueVo.getId()); // �봽濡쒖젥�듃 愿�由ъ옄�씪 寃쎌슦 �빐�떦 �봽濡쒖젥�듃�뿉 �벑濡앸맂 �씠�뒋�뒗 �닔�젙 沅뚰븳�쓣 媛뽯뒗�떎. - hasPermission = this.projectRoleUserService.checkProjectManager(issue.getProject()); + hasPermission = this.projectRoleUserService.checkProjectManager(issue.getProject(), user); break; case Issue.REGISTER: // �씠�뒋 �벑濡앹옄 - hasPermission = issueVo.getRegisterId().equals(this.webAppUtil.getLoginId()); + hasPermission = issueVo.getRegisterId().equals(user.getId()); break; case Issue.ASSIGNEE: @@ -1405,7 +1638,7 @@ } // �씠�뒋 �떞�떦�옄 �뿬遺� �솗�씤 for (UserVo issueUserVo : issueUserVos) { - if (issueUserVo.getId().equals(this.webAppUtil.getLoginId())) { + if (issueUserVo.getId().equals(user.getId())) { hasPermission = true; break; } @@ -1435,20 +1668,22 @@ // �씠�뒋 �긽�깭 蹂�寃� @Override @Transactional - public void modifyIssueStatus(IssueForm issueForm) { + public void modifyIssueStatus(IssueForm issueForm, User user) { // �궗�슜�븯怨� �엳�뒗 �뾽臾� 怨듦컙�씠 �솢�꽦 �긽�깭�씤吏� �솗�씤�븳�떎. �궗�슜 怨듦컙�뿉�꽌 濡쒓렇�씤�븳 �궗�슜�옄媛� 鍮꾪솢�꽦�씤吏� �솗�씤�븳�떎. this.workspaceService.checkUseWorkspace(); // 蹂�寃� �씠�젰 �젙蹂� 異붿텧 StringBuilder detectIssueChange = new StringBuilder(); // �씠�뒋 �닔�젙 沅뚰븳 泥댄겕 - this.verifyIssueModifyPermission(issueForm.getId()); Issue issue = this.getIssue(issueForm.getId()); + IssueStatus oldIssueStatus = issue.getIssueStatus(); + + this.verifyIssueModifyPermission(issue, user); IssueStatus issueStatus = this.issueStatusService.getIssueStatus(issueForm.getIssueStatusId()); // �씠�뒋 �긽�깭瑜� 蹂�寃쏀븷 �븣 �꽑�깮�븳 �씠�뒋 �긽�깭濡� 蹂�寃쏀븷 �닔 �엳�뒗吏� �솗�씤�븳�떎. this.issueStatusService.checkNextIssueStatus(issue, issueStatus); // 蹂�寃� �씠�젰 �젙蹂� 異붿텧 - this.issueHistoryService.detectIssueStatus(issue, issueForm, detectIssueChange, issueStatus); + this.issueHistoryService.detectIssueStatus(issue, issueForm, detectIssueChange, oldIssueStatus, issueStatus); issue.setIssueStatus(issueStatus); this.issueRepository.saveAndFlush(issue); @@ -1482,13 +1717,15 @@ @Override @Transactional public void modifyIssueUser(IssueForm issueForm) { + User user = this.webAppUtil.getLoginUserObject(); + // �궗�슜�븯怨� �엳�뒗 �뾽臾� 怨듦컙�씠 �솢�꽦 �긽�깭�씤吏� �솗�씤�븳�떎. �궗�슜 怨듦컙�뿉�꽌 濡쒓렇�씤�븳 �궗�슜�옄媛� 鍮꾪솢�꽦�씤吏� �솗�씤�븳�떎. this.workspaceService.checkUseWorkspace(); // 蹂�寃� �씠�젰 �젙蹂� 異붿텧 StringBuilder detectIssueChange = new StringBuilder(); // �씠�뒋 �닔�젙 沅뚰븳 泥댄겕 - this.verifyIssueModifyPermission(issueForm.getId()); Issue issue = this.getIssue(issueForm.getId()); + this.verifyIssueModifyPermission(issue, user); issue.setProject(this.projectService.getProject(issueForm.getProjectId())); // 蹂�寃� �씠�젰 �젙蹂� 異붿텧 @@ -1517,13 +1754,14 @@ @Override @Transactional public void modifyIssueDepartment(IssueForm issueForm) { + User user = this.webAppUtil.getLoginUserObject(); // �궗�슜�븯怨� �엳�뒗 �뾽臾� 怨듦컙�씠 �솢�꽦 �긽�깭�씤吏� �솗�씤�븳�떎. �궗�슜 怨듦컙�뿉�꽌 濡쒓렇�씤�븳 �궗�슜�옄媛� 鍮꾪솢�꽦�씤吏� �솗�씤�븳�떎. this.workspaceService.checkUseWorkspace(); // 蹂�寃� �씠�젰 �젙蹂� 異붿텧 StringBuilder detectIssueChange = new StringBuilder(); // �씠�뒋 �닔�젙 沅뚰븳 泥댄겕 - this.verifyIssueModifyPermission(issueForm.getId()); Issue issue = this.getIssue(issueForm.getId()); + this.verifyIssueModifyPermission(issue, user); issue.setProject(this.projectService.getProject(issueForm.getProjectId())); // 蹂�寃� �씠�젰 �젙蹂� 異붿텧 @@ -1555,6 +1793,7 @@ @Transactional public void removeIssues(IssueForm issueForm) { // �궗�슜�븯怨� �엳�뒗 �뾽臾� 怨듦컙�씠 �솢�꽦 �긽�깭�씤吏� �솗�씤�븳�떎. �궗�슜 怨듦컙�뿉�꽌 濡쒓렇�씤�븳 �궗�슜�옄媛� 鍮꾪솢�꽦�씤吏� �솗�씤�븳�떎. + User user = this.webAppUtil.getLoginUserObject(); this.workspaceService.checkUseWorkspace(); if (issueForm.getRemoveIds().size() < 1) { @@ -1565,7 +1804,7 @@ List<Issue> removeIssues = Lists.newArrayList(); for (Long issueId : issueForm.getRemoveIds()) { - Issue issue = this.issueRemoves(issueId); + Issue issue = this.issueRemoves(issueId, user); removeIssues.add(issue); } @@ -1577,10 +1816,10 @@ log.info(ElasticSearchUtil.makeUserActiveHistoryMessage(this.webAppUtil.getLoginUser(), ElasticSearchConstants.ISSUE_REMOVE)); } - private Issue issueRemoves(Long issueId) { + private Issue issueRemoves(Long issueId, User user) { Issue issue = this.getIssue(issueId); // �씠�뒋 �닔�젙 沅뚰븳�쓣 媛뽮퀬 �엳�뒗吏� �솗�씤 - this.verifyIssueModifyPermission(issueId); + this.verifyIssueModifyPermission(issue, user); // �씠�뒋 泥⑤� �뙆�씪�쓣 �궘�젣�븳�떎. if (issue.getAttachedFiles().size() > 0) { @@ -1744,7 +1983,8 @@ issueCondition.setIssueIds(Lists.newArrayList()); // Map �뿉 �엳�뒗 �뜲�씠�꽣瑜� IssueVo �뜲�씠�꽣濡� 蹂��솚�븳�떎. - this.setMapToIssueVo(results, issueVos, issueCondition); + User user = this.webAppUtil.getLoginUserObject(); + this.setMapToIssueVo(results, issueVos, issueCondition, user); // IssueVos �뜲�씠�꽣瑜� �뿊���뿉�꽌 �몴�떆�븷 �닔 �엳�뒗 �뜲�씠�꽣濡� 蹂�寃쏀븳�떎. List<Map<String, String>> convertExcelViewToIssueMaps = this.convertExcelViewToIssueVos(issueVos); @@ -1897,15 +2137,11 @@ result.put("customField_" + issueCustomFieldValueVo.getCustomFieldVo().getId().toString(), useValue + ", " + issueCustomFieldValueVo.getUseValue()); } } - - //�뾽泥�, ISP, �샇�뒪�똿 異붽� - results.add(result); } catch (Exception e) { log.error("�뿊�� �떎�슫濡쒕뱶 �삤瑜� 諛쒖깮"); } } - return results; } @@ -1916,10 +2152,12 @@ // �궗�슜�븯怨� �엳�뒗 �뾽臾� 怨듦컙�씠 �솢�꽦 �긽�깭�씤吏� �솗�씤�븳�떎. �궗�슜 怨듦컙�뿉�꽌 濡쒓렇�씤�븳 �궗�슜�옄媛� 鍮꾪솢�꽦�씤吏� �솗�씤�븳�떎. this.workspaceService.checkUseWorkspace(); + User user = this.webAppUtil.getLoginUserObject(); + for (Long issueId : issueForm.getIds()) { issueForm.setId(issueId); // �씠�뒋 �긽�깭 蹂�寃� - this.modifyIssueStatus(issueForm); + this.modifyIssueStatus(issueForm, user); } // �떞�떦 遺��꽌 �닔�젙 @@ -2845,7 +3083,7 @@ StringBuilder sb = new StringBuilder(); Issue parentIssue = issue.getParentIssue(); //蹂�寃� �쟾 �븯�쐞�씠�뒋�쓽 �긽�쐞�씠�뒋 - if(parentIssue != null){ //蹂�寃� �쟾 �븯�쐞�씠�뒋�쓽 �긽�쐞�씠�뒋媛� 議댁옱 �븷 寃쎌슦 + if(parentIssue != null && parentIssue.getId().equals(newParentIssueId)){ //蹂�寃� �쟾 �븯�쐞�씠�뒋�쓽 �긽�쐞�씠�뒋媛� 議댁옱 �븷 寃쎌슦 this.issueHistoryService.detectDownIssues(IssueHistoryType.DELETE, issue, sb); this.issueHistoryService.addIssueHistory(parentIssue, IssueHistoryType.MODIFY, sb.toString()); } @@ -2854,7 +3092,7 @@ parentIssue = this.getIssue(newParentIssueId); //�긽�쐞�씠�뒋(myIssue) issue.setParentIssue(parentIssue); //myIssue瑜� �븯�쐞�씠�뒋�쓽 �긽�쐞�씠�뒋濡� set this.issueHistoryService.detectDownIssues(IssueHistoryType.ADD, issue, sb); //issue = �븯�쐞�씠�뒋 - } else { + } else{ // �궘�젣 �븷 寃쎌슦 this.issueHistoryService.detectDownIssues(IssueHistoryType.DELETE, issue, sb); issue.setParentIssue(null); @@ -2879,4 +3117,4 @@ resJsonData.put(Constants.RES_KEY_CONTENTS, usePartnerVos); } } -} +} \ No newline at end of file -- Gitblit v1.8.0