From 257766aa7e8a88b2b371fc6f8f52751af7d84eda Mon Sep 17 00:00:00 2001 From: wyu <kknd09321@nate.com> Date: 수, 08 12월 2021 21:54:40 +0900 Subject: [PATCH] 연관 ,하위 이슈 요청 횟수 수정 --- src/main/java/kr/wisestone/owl/service/impl/IssueServiceImpl.java | 651 ++++++++++++++++++++++++++++++++++++++++++++++++----------- 1 files changed, 528 insertions(+), 123 deletions(-) diff --git a/src/main/java/kr/wisestone/owl/service/impl/IssueServiceImpl.java b/src/main/java/kr/wisestone/owl/service/impl/IssueServiceImpl.java index b8b83f9..8e77478 100644 --- a/src/main/java/kr/wisestone/owl/service/impl/IssueServiceImpl.java +++ b/src/main/java/kr/wisestone/owl/service/impl/IssueServiceImpl.java @@ -1,12 +1,14 @@ package kr.wisestone.owl.service.impl; import com.google.common.collect.Lists; +import com.sun.org.apache.bcel.internal.generic.NEW; import kr.wisestone.owl.common.ExcelConditionCheck; import kr.wisestone.owl.config.CommonConfiguration; import kr.wisestone.owl.constant.Constants; import kr.wisestone.owl.constant.ElasticSearchConstants; import kr.wisestone.owl.constant.MsgConstants; import kr.wisestone.owl.constant.UsePartner; +import kr.wisestone.owl.data.CheckIssueData; import kr.wisestone.owl.domain.*; import kr.wisestone.owl.domain.enumType.CustomFieldType; import kr.wisestone.owl.domain.enumType.EmailType; @@ -15,7 +17,10 @@ import kr.wisestone.owl.exception.OwlRuntimeException; import kr.wisestone.owl.mapper.IssueMapper; import kr.wisestone.owl.mapper.ProjectMapper; +import kr.wisestone.owl.repository.IssueRelationRepository; import kr.wisestone.owl.repository.IssueRepository; +import kr.wisestone.owl.repository.UserDepartmentRepository; +import kr.wisestone.owl.repository.WorkflowDepartmentRepository; import kr.wisestone.owl.service.*; import kr.wisestone.owl.util.*; import kr.wisestone.owl.util.DateUtil; @@ -52,10 +57,10 @@ private IssueRepository issueRepository; @Autowired - private IssueTableConfigService issueTableConfigService; + private ProjectService projectService; @Autowired - private ProjectService projectService; + private IssueTableConfigService issueTableConfigService; @Autowired private IssueStatusService issueStatusService; @@ -77,15 +82,6 @@ @Autowired private ApiTokenService apiTokenService; - - @Autowired - private CompanyFieldService companyFieldService; - - @Autowired - private IspFieldService ispFieldService; - - @Autowired - private HostingFieldService hostingFieldService; @Autowired private CommonConfiguration configuration; @@ -163,6 +159,9 @@ private IssueRelationService issueRelationService; @Autowired + private IssueRelationRepository issueRelationRepository; + + @Autowired private ExcelView excelView; @Autowired @@ -173,6 +172,12 @@ @Autowired private SimpMessagingTemplate simpMessagingTemplate; + + @Autowired + private UserDepartmentRepository userDepartmentRepository; + + @Autowired + private WorkflowDepartmentRepository workflowDepartmentRepository; @Override protected JpaRepository<Issue, Long> getRepository() { @@ -224,7 +229,6 @@ } } - // �봽濡쒖젥�듃 �엯�젰 Project project = issueType.getProject(); if (project == null){ @@ -245,14 +249,25 @@ issueForm.setSeverityId(issueApiDefault.getSeverity().getId()); } - // 以묐났 媛� �븯�쐞 �씠�뒋濡� 泥섎━�븯湲� + // 以묐났 媛� �긽�쐞 �씠�뒋�쓽 �븯�쐞 �씠�뒋濡� 泥섎━�븯湲� CustomFieldApiOverlapForm customFieldApiOverlapForm = new CustomFieldApiOverlapForm(); customFieldApiOverlapForm.setUserId(user.getId()); customFieldApiOverlapForm.setIssueTypeId(issueForm.getIssueTypeId()); - IssueVo issueVo = this.findIssue(issueApiForm, user.getId()); - if (issueVo != null) { - issueForm.setParentIssueId(issueVo.getId()); + // �긽�쐞�씪媛먯뿉 �궗�슜�븷 以묐났媛� �꽕�젙 + List<CustomFieldApiOverlap> customFieldApiOverlaps = this.customFieldApiOverlapService.find(user.getId(), issueApiForm.getIssueTypeId()); + for(int i=0; i < customFieldApiOverlaps.size() ; i++ ){ + CustomFieldApiOverlap customFieldApiOverlap = customFieldApiOverlaps.get(i); + issueApiForm.addUseIssueCustomFieldId(customFieldApiOverlap.getCustomField().getId()); + } + + List<IssueVo> issueVos = this.findIssue(issueApiForm, customFieldApiOverlaps, user.getId()); + int size = issueVos.size(); + if (size == 1) { + issueForm.setParentIssueId(issueVos.get(0).getId()); + } else if (size > 1) { + throw new OwlRuntimeException( + this.messageAccessor.getMessage(MsgConstants.API_OVERLAP_ERROR)); } issueForm.setIsApi(Issue.IS_API_YES); @@ -282,36 +297,74 @@ // API 瑜� �넻�빐 �씠�뒋 異붽�. @Override @Transactional - public Issue addApiIssue(IssueApiForm issueApiForm) { + public List<Issue> addApiIssue(IssueApiForm issueApiForm) throws CloneNotSupportedException { User user = convertToUser(issueApiForm.getToken()); IssueForm issueForm = this.convertToIssueForm(issueApiForm, user); - return addIssue(user, issueForm, issueApiForm.getMultipartFiles()); + List<Issue> issues = Lists.newArrayList(); + if (issueForm.getParentIssueId() != null) { + issues.add(addIssue(user, issueForm, issueApiForm.getMultipartFiles())); + } else { + // �긽�쐞 �씠�뒋 異붽� + IssueForm parentIssueForm = issueForm.clone(); + parentIssueForm.setUseIssueCustomFields(issueApiForm.getUseIssueCustomFieldIds()); + Issue issue = addIssue(user, parentIssueForm, null); + issues.add(issue); + // �븯�쐞 �씠�뒋 異붽� + issueForm.setParentIssueId(issue.getId()); + issues.add(addIssue(user, issueForm, issueApiForm.getMultipartFiles())); + } + + return issues; } - + // �긽�쐞 �씠�뒋 媛��졇�삤湲� + private IssueVo getParentIssueVo(Long parentIssueId) { + if (parentIssueId != null) { + Issue parentIssue = this.getIssue(parentIssueId); + return ConvertUtil.copyProperties(parentIssue, IssueVo.class); + } + return null; + } // 以묐났�맂 �긽�쐞 �씠�뒋 寃��깋 - private IssueVo findIssue(IssueApiForm issueApiForm, Long userId) { - IssueCustomFieldValueCondition issueCustomFieldValueCondition = new IssueCustomFieldValueCondition(); + private List<IssueVo> findIssue(IssueApiForm issueApiForm, List<CustomFieldApiOverlap> customFieldApiOverlaps, Long userId) { - List<CustomFieldApiOverlap> customFieldApiOverlaps = this.customFieldApiOverlapService.find(userId, issueApiForm.getIssueTypeId()); + List<IssueVo> resultIssueVos = new ArrayList<>(); + if (customFieldApiOverlaps != null && customFieldApiOverlaps.size() > 0) { for (CustomFieldApiOverlap customFieldApiOverlap : customFieldApiOverlaps) { for (IssueCustomFieldValueForm issueCustomFieldValue : issueApiForm.getIssueCustomFieldValues()) { + IssueCustomFieldValueCondition issueCustomFieldValueCondition = new IssueCustomFieldValueCondition(); + issueCustomFieldValueCondition.setUseParentIssueId(true); if (customFieldApiOverlap.getCustomField().getId().equals(issueCustomFieldValue.getCustomFieldId())) { - issueCustomFieldValueCondition.addUseValues(issueCustomFieldValue.getUseValue()); + issueCustomFieldValueCondition.setUseValue(issueCustomFieldValue.getUseValue()); + + List<Map<String, Object>> results = this.issueMapper.findByCustomFieldValue(issueCustomFieldValueCondition); + if (results != null && results.size() > 0) { + List<IssueVo> findIssueVos = new ArrayList<>(); + Collections.copy(resultIssueVos, findIssueVos); + resultIssueVos.clear(); + for (Map<String, Object> result : results) { + IssueVo issueVo = ConvertUtil.convertMapToClass(result, IssueVo.class); + if (findIssueVos.size() == 0) { + resultIssueVos.add(issueVo); + } else { + IssueVo findIssueVo = findIssueVo(findIssueVos, issueVo.getId()); + if (findIssueVo != null) { + resultIssueVos.add(findIssueVo); + } + } + } + } else { + resultIssueVos.clear(); + return resultIssueVos; + } } } } - List<Map<String, Object>> results = this.issueMapper.findByCustomFieldValue(issueCustomFieldValueCondition); - if (results != null && results.size() > 0) { - IssueVo issueVo = new IssueVo(); - ConvertUtil.convertMapToObject(results.get(0), issueVo); - return issueVo; - } } - return null; + return resultIssueVos; } // �씠�뒋瑜� �깮�꽦�븳�떎. @@ -342,7 +395,7 @@ // �궇吏� �쑀�슚�꽦 泥댄겕 this.checkStartCompleteDate(issueForm.getStartDate(), issueForm.getCompleteDate()); // �떞�떦 遺��꽌 �쑀�슚�꽦 泥댄겕 - this.verifyIssueDepartment(project, issueForm); + //this.verifyIssueDepartment(project, issueForm); // �씠�뒋 �긽�깭 �쑀�삎�씠 '��湲�' �씤 �씠�뒋 �긽�깭 媛��졇�삤湲� IssueStatus issueStatus = this.issueStatusService.findByIssueStatusTypeIsReady(issueType.getWorkflow()); @@ -374,6 +427,91 @@ // HOSTING �젙蹂� ���옣 this.issueHostingService.modifyIssueHostingField(issue, issueForm.getIssueHostingFields()); + + // 泥⑤� �뙆�씪 ���옣 + // multipartFile �쓣 file Map List 媛앹껜濡� 蹂�寃쏀븳�떎. + List<Map<String, Object>> convertFileMaps = this.convertMultipartFileToFile(multipartFiles); + this.attachedFileService.addAttachedFile(convertFileMaps, issue, user.getAccount()); + + // �뀓�뒪�듃 �뿉�뵒�꽣�뿉 泥⑤��븳 �뙆�씪�쓣 �씠�뒋�� �뿰寃� + this.checkNotHaveIssueIdAttachedFile(issue, issueForm); + // �궗�슜�옄 �젙�쓽 �븘�뱶 ���옣 + this.issueCustomFieldValueService.modifyIssueCustomFieldValue(issue, issueForm.getIssueCustomFields()); + // �씠�뒋 �씠�젰 �깮�꽦 + this.issueHistoryService.addIssueHistory(issue, user, IssueHistoryType.ADD, null); + // �씠�뒋 �쐞�뿕 愿�由� �깮�꽦 + this.issueRiskService.addIssueRisk(issue, project.getWorkspace()); + // �쁺�냽�꽦 而⑦뀓�뒪�듃 鍮꾩슦湲� + this.clear(); + // �씠�뒋 �깮�꽦, �궘�젣�떆 �삁�빟 �씠硫붿씪�뿉 �벑濡앺빐�넃�뒗�떎. + this.reservationIssueEmail(issue, EmailType.ISSUE_ADD); + // �궗�슜�옄 �떆�뒪�뀥 湲곕뒫 �궗�슜 �젙蹂� �닔吏� + + UserVo userVo = ConvertUtil.copyProperties(user, UserVo.class); + log.info(ElasticSearchUtil.makeUserActiveHistoryMessage(userVo, ElasticSearchConstants.ISSUE_ADD)); + + return issue; + } + + // �뿰愿��씠�뒋瑜� �깮�꽦�븳�떎. + @Override + @Transactional + public Issue addRelIssue(IssueForm issueForm, List<MultipartFile> multipartFiles) { + User user = this.webAppUtil.getLoginUserObject(); + return addRelIssue(user, issueForm, multipartFiles); + } + + // �뿰愿��씠�뒋瑜� �깮�꽦�븳�떎. + @Override + @Transactional + public Issue addRelIssue(User user, IssueForm issueForm, List<MultipartFile> multipartFiles) { + // �궗�슜�븯怨� �엳�뒗 �뾽臾� 怨듦컙�씠 �솢�꽦 �긽�깭�씤吏� �솗�씤�븳�떎. �궗�슜 怨듦컙�뿉�꽌 濡쒓렇�씤�븳 �궗�슜�옄媛� 鍮꾪솢�꽦�씤吏� �솗�씤�븳�떎. + Workspace workspace = this.workspaceService.checkUseWorkspace(user, user.getLastWorkspaceId()); + // �봽濡쒖젥�듃 �쑀�슚�꽦 泥댄겕 + Project project = this.projectService.getProject(issueForm.getProjectId()); + // �씠�뒋 �쑀�삎 �쑀�슚�꽦 泥댄겕 + IssueType issueType = this.issueTypeService.getIssueType(issueForm.getIssueTypeId()); + // �슦�꽑�닚�쐞 �쑀�슚�꽦 泥댄겕 + Priority priority = this.priorityService.getPriority(issueForm.getPriorityId()); + // 以묒슂�룄 �쑀�슚�꽦 泥댄겕 + Severity severity = this.severityService.getSeverity(issueForm.getSeverityId()); + + // �젣紐� �쑀�슚�꽦 泥댄겕 + this.verifyTitle(issueForm.getTitle()); + // �궇吏� �쑀�슚�꽦 泥댄겕 + this.checkStartCompleteDate(issueForm.getStartDate(), issueForm.getCompleteDate()); + // �떞�떦 遺��꽌 �쑀�슚�꽦 泥댄겕 + //this.verifyIssueDepartment(project, issueForm); + + // �씠�뒋 �긽�깭 �쑀�삎�씠 '��湲�' �씤 �씠�뒋 �긽�깭 媛��졇�삤湲� + IssueStatus issueStatus = this.issueStatusService.findByIssueStatusTypeIsReady(issueType.getWorkflow()); + + Issue issue = ConvertUtil.copyProperties(issueForm, Issue.class); + issue.setProject(project); + issue.setIssueStatus(issueStatus); + issue.setIssueType(issueType); + issue.setPriority(priority); + issue.setSeverity(severity); + if (issueForm.getParentIssueId() != null){ + Issue parentIssue = this.getIssue(issueForm.getParentIssueId()); + issue.setParentIssue(parentIssue); + } + + issue.setIssueNumber(this.issueNumberGeneratorService.generateIssueNumber(project)); // 媛� �봽濡쒖젥�듃�쓽 怨좎쑀 �씠�뒋 踰덊샇 �깮�꽦 + + issue = this.issueRepository.saveAndFlush(issue); + + issue.setReverseIndex(issue.getId() * -1); // 荑쇰━ �냽�룄 媛쒖꽑�쓣 �쐞�빐 由щ쾭�뒪 �씤�뜳�뒪 �깮�꽦 + // �떞�떦�옄 吏��젙 + //this.issueUserService.modifyIssueUser(issue, project.getWorkspace(), issueForm.getUserIds()); + // �떞�떦遺��꽌 吏��젙 + this.issueDepartmentService.modifyIssueDepartment(issue, user, project.getWorkspace(), issueForm.getDepartmentIds()); + // �뾽泥� �젙蹂� ���옣 + this.issueCompanyService.modifyIssueCompanyField(issue, issueForm.getIssueCompanyFields()); + // ISP �젙蹂� ���옣 + this.issueIspService.modifyIssueIspField(issue, issueForm.getIssueIspFields()); + // HOSTING �젙蹂� ���옣 + this.issueHostingService.modifyIssueHostingField(issue, issueForm.getIssueHostingFields()); // 泥⑤� �뙆�씪 ���옣 // multipartFile �쓣 file Map List 媛앹껜濡� 蹂�寃쏀븳�떎. @@ -548,11 +686,41 @@ } } + void SetMyDepartmentId(IssueCondition issueCondition){ + Long loginId = issueCondition.getLoginUserId(); + List<Long> myDepartmentIds = Lists.newArrayList(); + List<UserDepartment> myDepartments = this.userDepartmentRepository.findByUserId(loginId); + + if(myDepartments != null && myDepartments.size() > 0){ + for(UserDepartment myDepartment : myDepartments){ + myDepartmentIds.add(myDepartment.getDepartmentId()); + } + } + issueCondition.setMyDepartmentIds(myDepartmentIds); + } + + void SetWorkflowDepartment(List<IssueVo> issueVos){ + for(IssueVo issueVo : issueVos){ + Long issueTypeId = issueVo.getIssueTypeId(); + IssueType issueType = this.issueTypeService.getIssueType(issueTypeId); + Long workflowId = issueType.getWorkflow().getId(); + List<WorkflowDepartment> workflowDepartmentList = this.workflowDepartmentRepository.findByWorkflowId(workflowId); + List<Long> workflowDepartmentIds = Lists.newArrayList(); + if(workflowDepartmentList != null && workflowDepartmentList.size()>0){ + for(WorkflowDepartment workflowDepartment : workflowDepartmentList){ + workflowDepartmentIds.add(workflowDepartment.getDepartment().getId()); + } + } + if(issueVo.getIssueTypeId().equals(issueTypeId)){ + issueVo.setWorkflowDepartmentIds(workflowDepartmentIds); + } + } + } + // �씠�뒋 紐⑸줉�쓣 議고쉶�븳�떎. @Override @Transactional(readOnly = true) - public List<IssueVo> findIssue(Map<String, Object> resJsonData, - IssueCondition issueCondition, Pageable pageable) { + public List<IssueVo> findIssue(Map<String, Object> resJsonData, IssueCondition issueCondition, Pageable pageable) { // 寃��깋 議곌굔�쓣 留뚮뱺�떎 if (!this.makeIssueSearchCondition(issueCondition, Lists.newArrayList("01", "02", "03"), pageable)) { @@ -578,12 +746,26 @@ List<String> issueKeys = Lists.newArrayList(issueIds); issueCondition.setIssueIds(issueKeys); - List<Map<String, Object>> results = this.issueMapper.find(issueCondition); + issueCondition.setLoginUserId(this.webAppUtil.getLoginId()); + issueCondition.setWorkspaceId(this.userService.getUser(this.webAppUtil.getLoginId()).getLastWorkspaceId()); + User user = this.webAppUtil.getLoginUserObject(); + + List<Map<String, Object>> results = Lists.newArrayList(); + Long totalCount = 0L; + + if (this.userWorkspaceService.checkWorkspaceManager(user)) { + results = this.issueMapper.find(issueCondition); + totalCount = this.issueMapper.count(issueCondition); + } else{ + this.SetMyDepartmentId(issueCondition); + results = this.issueMapper.findByDepartment(issueCondition); + totalCount = this.issueMapper.countByDepartment(issueCondition); + } + // �뒠�떇 �쟾 - 0.8, 0.9, 0.9, 0.9, 0.9 /*StopWatch serviceStart = new StopWatch(); serviceStart.start();*/ - Long totalCount = this.issueMapper.count(issueCondition); // �뒠�떇 �쟾 - 1.1, 1.1, 1.3, 1.2 /*serviceStart.stop(); @@ -593,9 +775,10 @@ // �씠�뒋 �븘�씠�뵒 珥덇린�솕 issueCondition.setIssueIds(Lists.newArrayList()); // Map �뿉 �엳�뒗 �뜲�씠�꽣瑜� IssueVo �뜲�씠�꽣濡� 蹂��솚�븳�떎. - this.setMapToIssueVo(results, issueVos, issueCondition); + this.setMapToIssueVo(results, issueVos, issueCondition, user); this.setCountDownIssues(results, issueVos); + this.SetWorkflowDepartment(issueVos); //�썙�겕�뵆濡쒖슦�뿉 �꽕�젙�븳 �떞�떦遺��꽌 媛��졇�삤湲� resJsonData.put(Constants.RES_KEY_CONTENTS, issueVos); resJsonData.put(Constants.REQ_KEY_PAGE_VO, new ResPage(pageable.getPageNumber(), pageable.getPageSize(), @@ -606,21 +789,33 @@ return issueVos; } - private void setCountDownIssues(List<Map<String, Object>> results, List<IssueVo> issueVos) { + @Override + @Transactional(readOnly = true) + public void setCountDownIssues(List<Map<String, Object>> results, List<IssueVo> issueVos) { for (Map<String, Object> result : results){ List<Issue> downIssues = this.issueRepository.findByParentIssueId((Long) result.get("id")); //�븯�쐞�씠�뒋 媛��졇�삤湲� if(downIssues != null && downIssues.size() > 0){ //�긽�쐞�씠�뒋 媛�吏�怨� �엳�뒗 �븷�뱾�씠 �엳�쑝硫� - int downIssueCount = 0; + int downIssueAllCount = 0;// �븯�쐞�씠�뒋 �쟾泥� 移댁슫�듃 + int downIssueCount = 0;// �븯�쐞�씠�뒋 誘몄셿猷� 移댁슫�듃 for(Issue downIssue : downIssues){ - downIssueCount ++; + downIssueAllCount ++; Long parentIssueId = downIssue.getParentIssue().getId(); Issue parentIssue = this.getIssue(parentIssueId); IssueVo parentIssueVo = ConvertUtil.copyProperties(parentIssue, IssueVo.class); - parentIssueVo.setDownIssueCount(downIssueCount); + parentIssueVo.setDownIssueAllCount(downIssueAllCount); + + IssueStatus downIssueStatus = this.issueStatusService.getIssueStatus(downIssue.getIssueStatus().getId()); + IssueVo downIssueVo = ConvertUtil.copyProperties(downIssue, IssueVo.class); + downIssueVo.setIssueStatusType(downIssueStatus.getIssueStatusType().toString()); + + if(!downIssueVo.getIssueStatusType().equals("CLOSE")){ //誘몄셿猷� �븯�쐞�씠�뒋 泥댄겕 + downIssueCount ++; + } for(IssueVo issueVo : issueVos){ if(issueVo.getId().equals(parentIssueVo.getId())){ - issueVo.setDownIssueCount(parentIssueVo.getDownIssueCount()); + issueVo.setDownIssueCount(downIssueCount); + issueVo.setDownIssueAllCount(parentIssueVo.getDownIssueAllCount()); } } } @@ -732,7 +927,9 @@ IssueCondition issueCondition = new IssueCondition(); // 寃��깋 議곌굔�쓣 留뚮뱺�떎 - if (!this.makeIssueSearchCondition(issueCondition, projectCondition, pageable)) { + + User user = this.webAppUtil.getLoginUserObject(); + if (!this.makeIssueSearchCondition(user, issueCondition, projectCondition, pageable)) { // �씠�뒋 紐⑸줉�쓣 李얠� 紐삵븷 寃쎌슦 湲곕낯 �젙蹂대줈 由ы꽩�븳�떎. this.notFoundIssueList(resJsonData, pageable); return Lists.newArrayList(); @@ -776,7 +973,7 @@ } // Map �뿉 �엳�뒗 �뜲�씠�꽣瑜� IssueVo �뜲�씠�꽣濡� 蹂��솚�븳�떎. - private void setMapToIssueVo(List<Map<String, Object>> results, List<IssueVo> issueVos, IssueCondition issueCondition) { + private void setMapToIssueVo(List<Map<String, Object>> results, List<IssueVo> issueVos, IssueCondition issueCondition, User user) { for (Map<String, Object> result : results) { IssueVo issueVo = ConvertUtil.convertMapToClass(result, IssueVo.class); issueVos.add(issueVo); @@ -785,7 +982,7 @@ // �씠�뒋 �궗�슜�옄 �젙蹂� 異붽� //this.setIssueUserList(issueVos, issueCondition); - this.setIssueDepartmentList(issueVos, issueCondition); + this.setIssueDepartmentList(issueVos, issueCondition, user); // �벑濡앹옄 �젙蹂� 異붽� this.setRegister(issueVos); // �떞�떦�옄 �젙蹂� �뀑�똿 @@ -832,7 +1029,7 @@ } // 寃��깋 議곌굔�쓣 留뚮뱺�떎 - private boolean makeIssueSearchCondition(IssueCondition condition, ProjectCondition projectCondition, Pageable pageable) { + private boolean makeIssueSearchCondition(User user, IssueCondition condition, ProjectCondition projectCondition, Pageable pageable) { if (pageable != null) { condition.setPage(pageable.getPageNumber() * pageable.getPageSize()); condition.setPageSize(pageable.getPageSize()); @@ -850,7 +1047,7 @@ // �봽濡쒖젥�듃瑜� �꽑�깮�븯吏� �븡�븯�쑝硫� �빐�떦 �뾽臾� 怨듦컙�뿉�꽌 李몄뿬�븯怨� �엳�뒗 �봽濡쒖젥�듃瑜� 李얜뒗�떎. if (condition.getProjectIds().size() < 1) { List<Map<String, Object>> projects = null; - if (this.userWorkspaceService.checkWorkspaceManager()) { + if (this.userWorkspaceService.checkWorkspaceManager(user)) { projects = this.projectMapper.findByWorkspaceManagerAll(projectCondition); } else { projects = this.projectService.findByWorkspaceIdAndIncludeProjectAll(projectCondition); @@ -928,7 +1125,7 @@ } // �씠�뒋 �떞�떦�옄 �젙蹂대�� �뀑�똿�븳�떎. - private void setIssueUserList(List<IssueVo> issueVos, IssueCondition issueCondition) { + private void setIssueUserList(List<IssueVo> issueVos, IssueCondition issueCondition, User user) { if (issueVos.size() < 1) { return; } @@ -959,14 +1156,14 @@ } // �씠�뒋 �닔�젙 沅뚰븳�쓣 媛뽮퀬 �엳�뒗吏� �솗�씤 - if (this.checkHasPermission(issueVo, issueVo.getUserVos())) { + if (this.checkHasPermission(issueVo, issueVo.getUserVos(), user)) { issueVo.setModifyPermissionCheck(Boolean.TRUE); } } } // �씠�뒋 �떞�떦遺��꽌 �젙蹂대�� �뀑�똿�븳�떎. - private void setIssueDepartmentList(List<IssueVo> issueVos, IssueCondition issueCondition) { + private void setIssueDepartmentList(List<IssueVo> issueVos, IssueCondition issueCondition, User user) { if (issueVos.size() < 1) { return; } @@ -996,7 +1193,7 @@ } // �씠�뒋 �닔�젙 沅뚰븳�쓣 媛뽮퀬 �엳�뒗吏� �솗�씤 - if (this.checkHasPermission(issueVo, issueVo.getUserVos())) { + if (this.checkHasPermission(issueVo, issueVo.getUserVos(), user)) { issueVo.setModifyPermissionCheck(Boolean.TRUE); } } @@ -1032,6 +1229,7 @@ case "02": // �봽濡쒖젥�듃, �씠�뒋 �쑀�삎, �씠�뒋 �긽�깭, �슦�꽑�닚�쐞, 以묒슂�룄, �떞�떦�옄, 泥⑤��뙆�씪, �궗�슜�옄 �젙�쓽 �븘�뱶 �젙蹂�, �뙎湲�, 湲곕줉�쓣 �뀑�똿�븳�떎. this.setIssueDetail(issueVo, issue); // �씠�뒋 �긽�꽭 �젙蹂대�� �뀑�똿�븳�떎. + this.setIssueTableConfigs(issue, issueVo); issueVo.setProjectVo(ConvertUtil.copyProperties(issue.getProject(), ProjectVo.class)); break; } @@ -1043,41 +1241,49 @@ resJsonData.put(Constants.RES_KEY_CONTENTS, issueVo); } + // �뀒�씠釉� �꽕�젙 �뀑�똿 + private void setIssueTableConfigs(Issue issue, IssueVo issueVo) { + Long IssueTypeId = issue.getIssueType().getId(); + + for (int tableConfigType : IssueTableConfig.IssueTableTypes) { + if (tableConfigType != IssueTableConfig.ISSUE_TABLE_TYPE_MAIN) { + issueVo.addIssueTableConfigVo(createIssueTableConfigVo(IssueTypeId, tableConfigType)); + } + } + } + + private IssueTableConfigVo createIssueTableConfigVo(Long issueTypeId, int tableConfigType) { + IssueTableConfig issueTableConfig = this.issueTableConfigService.findByUserIdAndWorkspaceIdAndIssueTypeIdAndIssueTableType(issueTypeId, tableConfigType); + if (issueTableConfig != null) { + return ConvertUtil.copyProperties(issueTableConfig, IssueTableConfigVo.class); + } + return new IssueTableConfigVo(); + } + + // �븯�쐞 �씠�뒋 �젙蹂대�� �뀑�똿�븳�떎 private void setDownIssues(Issue issue, IssueVo issueVo) { List<Issue> downIssues = this.issueRepository.findByParentIssueId(issue.getId()); - /*if(issueVo != null && downIssues.size()>0){ - for(Issue downIssue : downIssues){ - IssueVo downIssueVo = ConvertUtil.copyProperties(downIssue, IssueVo.class); - IssueDownVo issueDownVo = ConvertUtil.copyProperties(downIssueVo, IssueDownVo.class); - issueDownVo.setIssueDown(downIssueVo); - issueDownVo.setTitle(downIssue.getTitle()); - issueDownVo.setIssueTypeVo(ConvertUtil.copyProperties(downIssue.getIssueType(), IssueTypeVo.class)); - issueDownVo.setPriorityVo(ConvertUtil.copyProperties(downIssue.getPriority(), PriorityVo.class)); - issueDownVo.setSeverityVo(ConvertUtil.copyProperties(downIssue.getSeverity(), SeverityVo.class)); - this.setRegister(downIssue, downIssueVo); // �벑濡앹옄 - this.setIssueDepartment(downIssue, downIssueVo); // �떞�떦遺��꽌 �젙蹂� �뀑�똿 - this.setIssueCustomFields(downIssue, downIssueVo); // �궗�슜�옄�젙�쓽�븘�뱶 �젙蹂� �꽭�똿 - issueVo.addIssueDownVo(issueDownVo); - } - }*/ - - List<IssueVo> downIssueVos = ConvertUtil.convertObjectsToClasses(downIssues, IssueVo.class); - List<IssueVo> resultList = new ArrayList<>(); - if(downIssueVos != null && downIssueVos.size()>0){ - for(IssueVo downIssueVo : downIssueVos){ + if(downIssues != null && downIssues.size()>0){ + List<IssueVo> resultList = new ArrayList<>(); for(Issue downIssue : downIssues){ + IssueVo downIssueVo = ConvertUtil.copyProperties(downIssue, IssueVo.class); downIssueVo.setIssueTypeVo(ConvertUtil.copyProperties(downIssue.getIssueType(), IssueTypeVo.class)); downIssueVo.setPriorityVo(ConvertUtil.copyProperties(downIssue.getPriority(), PriorityVo.class)); downIssueVo.setSeverityVo(ConvertUtil.copyProperties(downIssue.getSeverity(), SeverityVo.class)); + //�씠�뒋 �긽�깭 異붽� + IssueStatusVo issueStatusVo = ConvertUtil.copyProperties(downIssue.getIssueStatus(), IssueStatusVo.class, "issueStatusType"); + issueStatusVo.setIssueStatusType(downIssue.getIssueStatus().getIssueStatusType().toString()); + downIssueVo.setIssueStatusVo(issueStatusVo); + this.setRegister(downIssue, downIssueVo); // �벑濡앹옄 this.setIssueDepartment(downIssue, downIssueVo); // �떞�떦遺��꽌 �젙蹂� �뀑�똿 this.setIssueCustomFields(downIssue, downIssueVo); // �궗�슜�옄�젙�쓽�븘�뱶 �젙蹂� �꽭�똿 + + resultList.add(downIssueVo); } - resultList.add(downIssueVo); + issueVo.setIssueDownVos(resultList); } - issueVo.setIssueDownVos(resultList); - } } // �씠�뒋 �긽�꽭 �젙蹂대�� �뀑�똿�븳�떎. @@ -1168,6 +1374,11 @@ issueRelationVo.setIssueTypeVo(ConvertUtil.copyProperties(relationIssue.getIssueType(), IssueTypeVo.class)); issueRelationVo.setPriorityVo(ConvertUtil.copyProperties(relationIssue.getPriority(), PriorityVo.class)); issueRelationVo.setSeverityVo(ConvertUtil.copyProperties(relationIssue.getSeverity(), SeverityVo.class)); + //�씠�뒋 �긽�깭 異붽� + IssueStatusVo issueStatusVo = ConvertUtil.copyProperties(relationIssue.getIssueStatus(), IssueStatusVo.class, "issueStatusType"); + issueStatusVo.setIssueStatusType(relationIssue.getIssueStatus().getIssueStatusType().toString()); + issueRelationVo.setIssueStatusVo(issueStatusVo); + this.setRegister(relationIssue, relIssueVo); // �벑濡앹옄 this.setIssueDepartment(relationIssue, relIssueVo); // �떞�떦遺��꽌 �젙蹂� �뀑�똿 this.setIssueCustomFields(relationIssue, relIssueVo); // �궗�슜�옄�젙�쓽�븘�뱶 �젙蹂� �꽭�똿 @@ -1240,7 +1451,7 @@ } // �씠�뒋(�씠�뒋 �쑀�삎)�뿉 �뿰寃곕맂 �궗�슜�옄 �젙�쓽 �븘�뱶 �젙蹂대�� �뀑�똿�븳�떎. - private void setIssueCustomFields(Issue issue, IssueVo issueVo) { + private IssueVo setIssueCustomFields(Issue issue, IssueVo issueVo) { // �빐�떦 �봽濡쒖젥�듃�쓽 �씠�뒋 �쑀�삎�뿉 �뿰寃곕맂 �궗�슜�옄 �젙�쓽 �븘�뱶 �젙蹂대�� 媛��졇�삩�떎. IssueTypeCustomFieldCondition issueTypeCustomFieldCondition = new IssueTypeCustomFieldCondition(); @@ -1252,6 +1463,8 @@ // �씠�뒋�뿉�꽌 �궗�슜�맂 �궗�슜�옄 �젙�쓽 �븘�뱶 媛믪쓣 媛��졇�삩�떎. List<IssueCustomFieldValueVo> issueCustomFieldValueVos = this.issueCustomFieldValueService.findByIssueId(issue.getId()); issueVo.setIssueCustomFieldValueVos(issueCustomFieldValueVos); + + return issueVo; } // �씠�뒋�뿉 �벑濡앸맂 �뙎湲� �젙蹂대�� �뀑�똿�븳�떎. @@ -1264,13 +1477,113 @@ issueVo.setIssueHistoryVos(this.issueHistoryService.findIssueHistory(issue.getId())); } - // �씠�뒋瑜� �닔�젙�븳�떎 + // �궗�슜�옄 �젙�쓽 �븘�뱶 媛믪씠 媛숈� �씠�뒋 李얘린 @Override - public Issue modifyIssue(IssueApiForm issueApiForm, List<MultipartFile> files) { + @Transactional + public List<IssueVo> findIssue(IssueApiForm issueApiform) { + + List<IssueCustomFieldValueForm> issueCustomFieldValueForms = issueApiform.getIssueCustomFieldValues(); + List<IssueVo> resultIssueVos = new ArrayList<>(); + + IssueCustomFieldValueCondition issueCustomFieldValueCondition = new IssueCustomFieldValueCondition(); + issueCustomFieldValueCondition.setUseParentIssueId(false); + if (issueCustomFieldValueForms.size() > 0) { + for (IssueCustomFieldValueForm issueCustomFieldValueForm : issueCustomFieldValueForms) { + + CustomField customField = this.customFieldService.getCustomField(issueCustomFieldValueForm.getCustomFieldId()); + CustomFieldType customFieldType = CustomFieldType.DATETIME; + if (customFieldType.equals(customField.getCustomFieldType())) { + continue; + } +// issueCustomFieldValueCondition.addUseValue(issueCustomFieldValueForm.getUseValue()); + issueCustomFieldValueCondition.setUseValue(issueCustomFieldValueForm.getUseValue()); + List<Map<String, Object>> results = this.issueMapper.findByCustomFieldValue(issueCustomFieldValueCondition); + if (results != null && results.size() > 0) { + List<IssueVo> findIssueVos = new ArrayList<>(); + Collections.copy(resultIssueVos, findIssueVos); + resultIssueVos.clear(); + for (Map<String, Object> result : results) { + IssueVo issueVo = ConvertUtil.convertMapToClass(result, IssueVo.class); + + issueVo.setParentIssueVo(this.getParentIssueVo(MapUtil.getLong(result, "parentIssueId"))); + + if (findIssueVos.size() == 0) { + resultIssueVos.add(issueVo); + } else { + IssueVo findIssueVo = findIssueVo(findIssueVos, issueVo.getId()); + if (findIssueVo != null) { + resultIssueVos.add(findIssueVo); + } + } + } + } else { + resultIssueVos.clear(); + return resultIssueVos; + } + } + } + + return resultIssueVos; + } + + // 由ъ뒪�듃�뿉�꽌 �빐�떦 �븘�씠�뵒瑜� 媛�吏�怨� �엳�뒗 �씠�뒋 寃��깋 + private IssueVo findIssueVo(List<IssueVo> list, Long id) { + for (IssueVo issueVo : list) { + if (id.equals(issueVo.getId())) { + return issueVo; + } + } + return null; + } + + + // �븯�쐞 �씠�뒋媛� 紐⑤몢 醫낅즺 泥섎━ �릺�뿀�쓣 寃쎌슦 �긽�쐞�씠�뒋�룄 �셿猷� 泥섎━ + private void setParentIssueComplete(Issue parentIssue) { + if (parentIssue != null) { + this.issueMapper.findNotCompleteByParentIssueId(parentIssue.getId()); + + } + } + + + // �씠�뒋瑜� �닔�젙�븳�떎(api�슜) + @Override + @Transactional + public List<Issue> modifyIssue(IssueApiForm issueApiForm, List<MultipartFile> files) { User user = this.convertToUser(issueApiForm.getToken()); IssueForm issueForm = this.convertToIssueForm(issueApiForm, user); - return this.modifyIssue(user, issueForm, files); + List<IssueVo> issueVos = this.findIssue(issueApiForm); + if (issueVos != null && issueVos.size() > 0) { + List<Issue> issue = Lists.newArrayList(); + for (IssueVo issueVo : issueVos) { + IssueVo parentIssueVo = issueVo.getParentIssueVo(); + issueForm.setId(issueVo.getId()); + + // �옄�룞 醫낅즺 �긽�깭 �꽕�젙�씠 �릺�뼱 �엳吏� �븡�쑝硫� �삤瑜섎컻�깮 + Issue modifyIssue = this.modifyIssueForApi(user, issueForm, files); + Issue parentIssue = modifyIssue.getParentIssue(); + IssueType issueType = modifyIssue.getIssueType(); + IssueStatus issueStatus = issueType.getIssueStatus(); + if (issueStatus == null) { + throw new OwlRuntimeException(this.messageAccessor.getMessage(MsgConstants.API_COMPLETE_ISSUE_STATUS_NOT_EXIST)); + } + + if (parentIssue != null) { + List<Map<String, Object>> results = this.issueMapper.findNotCompleteByParentIssueId(parentIssue.getId()); + // �븯�쐞 �씪媛먯씠 紐⑤몢 醫낅즺 �긽�깭�씪�븣 �긽�쐞 �씪媛먮룄 醫낅즺 泥섎━ + if (results == null || results.size() == 0) { + parentIssue.setIssueStatus(issueType.getIssueStatus()); + } + } + + issue.add(modifyIssue); + } + return issue; + } else { + throw new OwlRuntimeException( + this.messageAccessor.getMessage(MsgConstants.API_ISSUE_NOT_EXIST)); + } } // �씠�뒋瑜� �닔�젙�븳�떎. @@ -1281,14 +1594,16 @@ return modifyIssue(user, issueForm, multipartFiles); } - // �씠�뒋瑜� �닔�젙�븳�떎. - @Override - @Transactional - public Issue modifyIssue(User user, IssueForm issueForm, List<MultipartFile> multipartFiles) { + // �닔�젙 �뜲�씠�꽣媛� �쑀�슚�븳吏� �솗�씤 + private CheckIssueData checkIssue(User user, IssueForm issueForm) { + // �궗�슜�븯怨� �엳�뒗 �뾽臾� 怨듦컙�씠 �솢�꽦 �긽�깭�씤吏� �솗�씤�븳�떎. �궗�슜 怨듦컙�뿉�꽌 濡쒓렇�씤�븳 �궗�슜�옄媛� 鍮꾪솢�꽦�씤吏� �솗�씤�븳�떎. this.workspaceService.checkUseWorkspace(user, user.getLastWorkspaceId()); + + Issue issue = this.getIssue(issueForm.getId()); + IssueStatus oldIssueStatus = issue.getIssueStatus(); // �씠�뒋 �닔�젙 沅뚰븳 泥댄겕 - this.verifyIssueModifyPermission(issueForm.getId()); + this.verifyIssueModifyPermission(issue, user); // �봽濡쒖젥�듃 �쑀�슚�꽦 泥댄겕 Project project = this.projectService.getProject(issueForm.getProjectId()); // �씠�뒋 �긽�깭 �쑀�슚�꽦 泥댄겕 @@ -1307,12 +1622,85 @@ // �떞�떦�옄 �쑀�슚�꽦 泥댄겕 //this.verifyIssueAssignee(project, issueForm); // �떞�떦遺��꽌 �쑀�슚�꽦 泥댄겕 - this.verifyIssueDepartment(project, issueForm); + //this.verifyIssueDepartment(project, issueForm); - Issue issue = this.getIssue(issueForm.getId()); + CheckIssueData checkIssueData = new CheckIssueData(); + checkIssueData.setIssue(issue); + checkIssueData.setProject(project); + checkIssueData.setOldIssueStatus(oldIssueStatus); + checkIssueData.setNewIssueStatus(issueStatus); + checkIssueData.setIssueType(issueType); + checkIssueData.setPriority(priority); + checkIssueData.setSeverity(severity); + + return checkIssueData; + } + + // �씠�뒋 �닔�젙(API�슜) + private Issue modifyIssueForApi(User user, IssueForm issueForm, List<MultipartFile> multipartFiles) { + CheckIssueData checkIssueData = this.checkIssue(user, issueForm); + + Issue issue = checkIssueData.getIssue(); + Project project = checkIssueData.getProject(); + IssueType issueType = checkIssueData.getIssueType(); + IssueStatus oldIssueStatus = checkIssueData.getOldIssueStatus(); + IssueStatus issueStatus = checkIssueData.getNewIssueStatus(); // 蹂�寃� �씠�젰 �젙蹂� 異붿텧 - StringBuilder detectIssueChange = this.issueHistoryService.detectIssueChange(issue, issueForm, project, issueStatus, issueType, priority, severity, multipartFiles); + StringBuilder detectIssueChange = this.issueHistoryService.detectIssueChange(issueForm, checkIssueData, multipartFiles); + + // �봽濡쒖젥�듃媛� 蹂�寃쎈릺硫� �씠�뒋 �꽆踰꾨�� �깉濡� �뵲�빞 �븳�떎. + this.checkChangeProject(checkIssueData.getProject(), issue); + + // �씠�뒋 �쑀�삎�씠 蹂�寃쎈릺�뿀�뒗吏� �솗�씤�븯怨� 蹂�寃쎈릺�뿀�떎硫� �씠�뒋 �긽�깭 �냽�꽦�씠 '��湲�' �씤 �씠�뒋 �긽�깭濡� 援먯껜�븳�떎. + if (this.checkChangeIssueType(issueType, issueStatus, issue)) { + issueStatus = this.issueStatusService.findByIssueStatusTypeIsReady(issueType.getWorkflow()); + // �씠�뒋 �긽�깭 蹂�寃� �씠�젰 �궓湲곌린 - �씠�젰�쓣 �궓湲곌린 �쐞�빐 issueForm �뿉 issueStatus Id 媛믪쓣 ���옣. + issueForm.setIssueStatusId(issueStatus.getId()); + this.issueHistoryService.detectIssueStatus(issue, issueForm, detectIssueChange, oldIssueStatus, issueStatus); + } + + issue = this.saveIssue(issueForm, checkIssueData); + + // �씠�뒋 �씠�젰 �벑濡� + if (!StringUtils.isEmpty(detectIssueChange.toString())) { + this.issueHistoryService.addIssueHistory(issue, user, IssueHistoryType.MODIFY, detectIssueChange.toString()); + } + // �궗�슜�옄 �떆�뒪�뀥 湲곕뒫 �궗�슜 �젙蹂� �닔吏� + UserVo userVo = ConvertUtil.copyProperties(user, UserVo.class); + log.info(ElasticSearchUtil.makeUserActiveHistoryMessage(userVo, ElasticSearchConstants.ISSUE_MODIFY)); + + return issue; + } + + private Issue saveIssue(IssueForm issueForm, CheckIssueData checkIssueData) { + Issue issue = checkIssueData.getIssue(); + ConvertUtil.copyProperties(issueForm, issue, "id"); + issue.setProject(checkIssueData.getProject()); + issue.setIssueStatus(checkIssueData.getNewIssueStatus()); + issue.setIssueType(checkIssueData.getIssueType()); + issue.setPriority(checkIssueData.getPriority()); + issue.setSeverity(checkIssueData.getSeverity()); + issue.setStartDate(issueForm.getStartDate()); + issue.setCompleteDate(issueForm.getCompleteDate()); + + return this.issueRepository.saveAndFlush(issue); + } + + // �씠�뒋瑜� �닔�젙�븳�떎. + @Override + @Transactional + public Issue modifyIssue(User user, IssueForm issueForm, List<MultipartFile> multipartFiles) { + CheckIssueData checkIssueData = this.checkIssue(user, issueForm); + + Issue issue = checkIssueData.getIssue(); + IssueStatus oldIssueStatus = checkIssueData.getOldIssueStatus(); + Project project = checkIssueData.getProject(); + IssueStatus issueStatus = checkIssueData.getNewIssueStatus(); + IssueType issueType = checkIssueData.getIssueType(); + + // 蹂�寃� �씠�젰 �젙蹂� 異붿텧 + StringBuilder detectIssueChange = this.issueHistoryService.detectIssueChange(issueForm, checkIssueData, multipartFiles); // �봽濡쒖젥�듃媛� 蹂�寃쎈릺硫� �씠�뒋 �꽆踰꾨�� �깉濡� �뵲�빞 �븳�떎. this.checkChangeProject(project, issue); @@ -1322,19 +1710,10 @@ issueStatus = this.issueStatusService.findByIssueStatusTypeIsReady(issueType.getWorkflow()); // �씠�뒋 �긽�깭 蹂�寃� �씠�젰 �궓湲곌린 - �씠�젰�쓣 �궓湲곌린 �쐞�빐 issueForm �뿉 issueStatus Id 媛믪쓣 ���옣. issueForm.setIssueStatusId(issueStatus.getId()); - this.issueHistoryService.detectIssueStatus(issue, issueForm, detectIssueChange, issueStatus); + this.issueHistoryService.detectIssueStatus(issue, issueForm, detectIssueChange, oldIssueStatus, issueStatus); } - ConvertUtil.copyProperties(issueForm, issue, "id"); - issue.setProject(project); - issue.setIssueStatus(issueStatus); - issue.setIssueType(issueType); - issue.setPriority(priority); - issue.setSeverity(severity); - issue.setStartDate(issueForm.getStartDate()); - issue.setCompleteDate(issueForm.getCompleteDate()); - - this.issueRepository.saveAndFlush(issue); + issue = this.saveIssue(issueForm, checkIssueData); //this.issueUserService.modifyIssueUser(issue, project.getWorkspace(), issueForm.getUserIds()); // �떞�떦遺��꽌 吏��젙 if(issueForm.getDepartmentIds().size()>0){ @@ -1357,7 +1736,8 @@ this.issueHistoryService.addIssueHistory(issue, user, IssueHistoryType.MODIFY, detectIssueChange.toString()); } // �궗�슜�옄 �떆�뒪�뀥 湲곕뒫 �궗�슜 �젙蹂� �닔吏� - log.info(ElasticSearchUtil.makeUserActiveHistoryMessage(this.webAppUtil.getLoginUser(), ElasticSearchConstants.ISSUE_MODIFY)); + UserVo userVo = ConvertUtil.copyProperties(user, UserVo.class); + log.info(ElasticSearchUtil.makeUserActiveHistoryMessage(userVo, ElasticSearchConstants.ISSUE_MODIFY)); // �뾽泥� �젙蹂� ���옣 this.issueCompanyService.modifyIssueCompanyField(issue, issueForm.getIssueCompanyFields()); @@ -1479,11 +1859,9 @@ } // �씠�뒋 �닔�젙 沅뚰븳 泥댄겕 - private void verifyIssueModifyPermission(Long issueId) { - Issue issue = this.getIssue(issueId); - + private void verifyIssueModifyPermission(Issue issue, User user) { // �씠�뒋 �닔�젙 沅뚰븳�쓣 媛뽮퀬 �엳�뒗吏� �솗�씤 - if (!this.checkHasPermission(ConvertUtil.copyProperties(issue, IssueVo.class), this.getIssueUserVos(issue))) { + if (!this.checkHasPermission(ConvertUtil.copyProperties(issue, IssueVo.class), this.getIssueUserVos(issue), user)) { throw new OwlRuntimeException( this.messageAccessor.getMessage(MsgConstants.ISSUE_NOT_MODIFY_PERMISSION)); } @@ -1493,24 +1871,31 @@ private List<UserVo> getIssueUserVos(Issue issue) { List<UserVo> userVos = Lists.newArrayList(); - for (IssueUser issueUser : issue.getIssueUsers()) { - UserVo userVo = ConvertUtil.copyProperties(issueUser.getUser(), UserVo.class, "password"); - userVos.add(userVo); + Set<IssueUser> issueUsers = issue.getIssueUsers(); + + try { + for (IssueUser issueUser : issueUsers) { + User user = issueUser.getUser(); + UserVo userVo = ConvertUtil.copyProperties(user, UserVo.class, "password"); + userVos.add(userVo); + } + } catch (Exception ex) { + } return userVos; } // �씠�뒋 �닔�젙 沅뚰븳�쓣 媛뽮퀬 �엳�뒗吏� �솗�씤 - private boolean checkHasPermission(IssueVo issueVo, List<UserVo> issueUserVos) { + private boolean checkHasPermission(IssueVo issueVo, List<UserVo> issueUserVos, User user) { boolean hasPermission = false; // �뾽臾� 怨듦컙 愿�由ъ옄�씪 寃쎌슦 �닔�젙 沅뚰븳�쓣 媛뽯뒗�떎. - hasPermission = this.checkIssueModifyPermission(hasPermission, Issue.WORKSPACE_MANAGER, issueVo, null, null); + hasPermission = this.checkIssueModifyPermission(hasPermission, Issue.WORKSPACE_MANAGER, issueVo, null, null, user); // �봽濡쒖젥�듃 愿�由ъ옄�씪 寃쎌슦 �빐�떦 �봽濡쒖젥�듃�뿉 �벑濡앸맂 �씠�뒋�뒗 �닔�젙 沅뚰븳�쓣 媛뽯뒗�떎. - hasPermission = this.checkIssueModifyPermission(hasPermission, Issue.PROJECT_MANAGER, issueVo, null, null); + hasPermission = this.checkIssueModifyPermission(hasPermission, Issue.PROJECT_MANAGER, issueVo, null, null, user); // �씠�뒋 �벑濡앹옄�씪 寃쎌슦 �닔�젙 沅뚰븳�쓣 媛뽯뒗�떎. - hasPermission = this.checkIssueModifyPermission(hasPermission, Issue.REGISTER, issueVo, null, null); + hasPermission = this.checkIssueModifyPermission(hasPermission, Issue.REGISTER, issueVo, null, null, user); // �씠�뒋 �떞�떦�옄�씪 寃쎌슦 �닔�젙 沅뚰븳�쓣 媛뽯뒗�떎. => �떞�떦遺��꽌濡� �닔�젙 - 泥댄겕 //hasPermission = this.checkIssueModifyPermission(hasPermission, Issue.ASSIGNEE, issueVo, issueUserVos); // �떞�떦�옄媛� �뾾�쑝硫� 紐⑤뱺 �궗�슜�옄媛� �닔�젙 沅뚰븳�쓣 媛뽯뒗�떎. @@ -1519,22 +1904,22 @@ } // �씠�뒋 �닔�젙 沅뚰븳�쓣 �솗�씤�븳�떎. - private boolean checkIssueModifyPermission(Boolean hasPermission, String checkType, IssueVo issueVo, List<UserVo> issueUserVos, List<DepartmentVo> issueDepartmentVos) { + private boolean checkIssueModifyPermission(Boolean hasPermission, String checkType, IssueVo issueVo, List<UserVo> issueUserVos, List<DepartmentVo> issueDepartmentVos, User user) { if (!hasPermission) { switch (checkType) { case Issue.WORKSPACE_MANAGER: // �뾽臾� 怨듦컙 愿�由ъ옄 // �뾽臾� 怨듦컙 愿�由ъ옄�씪 寃쎌슦 �닔�젙 沅뚰븳�쓣 媛뽯뒗�떎. - hasPermission = this.userWorkspaceService.checkWorkspaceManager(); + hasPermission = this.userWorkspaceService.checkWorkspaceManager(user); break; case Issue.PROJECT_MANAGER: // �봽濡쒖젥�듃 愿�由ъ옄 Issue issue = this.getIssue(issueVo.getId()); // �봽濡쒖젥�듃 愿�由ъ옄�씪 寃쎌슦 �빐�떦 �봽濡쒖젥�듃�뿉 �벑濡앸맂 �씠�뒋�뒗 �닔�젙 沅뚰븳�쓣 媛뽯뒗�떎. - hasPermission = this.projectRoleUserService.checkProjectManager(issue.getProject()); + hasPermission = this.projectRoleUserService.checkProjectManager(issue.getProject(), user); break; case Issue.REGISTER: // �씠�뒋 �벑濡앹옄 - hasPermission = issueVo.getRegisterId().equals(this.webAppUtil.getLoginId()); + hasPermission = issueVo.getRegisterId().equals(user.getId()); break; case Issue.ASSIGNEE: @@ -1545,7 +1930,7 @@ } // �씠�뒋 �떞�떦�옄 �뿬遺� �솗�씤 for (UserVo issueUserVo : issueUserVos) { - if (issueUserVo.getId().equals(this.webAppUtil.getLoginId())) { + if (issueUserVo.getId().equals(user.getId())) { hasPermission = true; break; } @@ -1575,20 +1960,22 @@ // �씠�뒋 �긽�깭 蹂�寃� @Override @Transactional - public void modifyIssueStatus(IssueForm issueForm) { + public void modifyIssueStatus(IssueForm issueForm, User user) { // �궗�슜�븯怨� �엳�뒗 �뾽臾� 怨듦컙�씠 �솢�꽦 �긽�깭�씤吏� �솗�씤�븳�떎. �궗�슜 怨듦컙�뿉�꽌 濡쒓렇�씤�븳 �궗�슜�옄媛� 鍮꾪솢�꽦�씤吏� �솗�씤�븳�떎. this.workspaceService.checkUseWorkspace(); // 蹂�寃� �씠�젰 �젙蹂� 異붿텧 StringBuilder detectIssueChange = new StringBuilder(); // �씠�뒋 �닔�젙 沅뚰븳 泥댄겕 - this.verifyIssueModifyPermission(issueForm.getId()); Issue issue = this.getIssue(issueForm.getId()); + IssueStatus oldIssueStatus = issue.getIssueStatus(); + + this.verifyIssueModifyPermission(issue, user); IssueStatus issueStatus = this.issueStatusService.getIssueStatus(issueForm.getIssueStatusId()); // �씠�뒋 �긽�깭瑜� 蹂�寃쏀븷 �븣 �꽑�깮�븳 �씠�뒋 �긽�깭濡� 蹂�寃쏀븷 �닔 �엳�뒗吏� �솗�씤�븳�떎. this.issueStatusService.checkNextIssueStatus(issue, issueStatus); // 蹂�寃� �씠�젰 �젙蹂� 異붿텧 - this.issueHistoryService.detectIssueStatus(issue, issueForm, detectIssueChange, issueStatus); + this.issueHistoryService.detectIssueStatus(issue, issueForm, detectIssueChange, oldIssueStatus, issueStatus); issue.setIssueStatus(issueStatus); this.issueRepository.saveAndFlush(issue); @@ -1622,13 +2009,15 @@ @Override @Transactional public void modifyIssueUser(IssueForm issueForm) { + User user = this.webAppUtil.getLoginUserObject(); + // �궗�슜�븯怨� �엳�뒗 �뾽臾� 怨듦컙�씠 �솢�꽦 �긽�깭�씤吏� �솗�씤�븳�떎. �궗�슜 怨듦컙�뿉�꽌 濡쒓렇�씤�븳 �궗�슜�옄媛� 鍮꾪솢�꽦�씤吏� �솗�씤�븳�떎. this.workspaceService.checkUseWorkspace(); // 蹂�寃� �씠�젰 �젙蹂� 異붿텧 StringBuilder detectIssueChange = new StringBuilder(); // �씠�뒋 �닔�젙 沅뚰븳 泥댄겕 - this.verifyIssueModifyPermission(issueForm.getId()); Issue issue = this.getIssue(issueForm.getId()); + this.verifyIssueModifyPermission(issue, user); issue.setProject(this.projectService.getProject(issueForm.getProjectId())); // 蹂�寃� �씠�젰 �젙蹂� 異붿텧 @@ -1657,13 +2046,14 @@ @Override @Transactional public void modifyIssueDepartment(IssueForm issueForm) { + User user = this.webAppUtil.getLoginUserObject(); // �궗�슜�븯怨� �엳�뒗 �뾽臾� 怨듦컙�씠 �솢�꽦 �긽�깭�씤吏� �솗�씤�븳�떎. �궗�슜 怨듦컙�뿉�꽌 濡쒓렇�씤�븳 �궗�슜�옄媛� 鍮꾪솢�꽦�씤吏� �솗�씤�븳�떎. this.workspaceService.checkUseWorkspace(); // 蹂�寃� �씠�젰 �젙蹂� 異붿텧 StringBuilder detectIssueChange = new StringBuilder(); // �씠�뒋 �닔�젙 沅뚰븳 泥댄겕 - this.verifyIssueModifyPermission(issueForm.getId()); Issue issue = this.getIssue(issueForm.getId()); + this.verifyIssueModifyPermission(issue, user); issue.setProject(this.projectService.getProject(issueForm.getProjectId())); // 蹂�寃� �씠�젰 �젙蹂� 異붿텧 @@ -1695,6 +2085,7 @@ @Transactional public void removeIssues(IssueForm issueForm) { // �궗�슜�븯怨� �엳�뒗 �뾽臾� 怨듦컙�씠 �솢�꽦 �긽�깭�씤吏� �솗�씤�븳�떎. �궗�슜 怨듦컙�뿉�꽌 濡쒓렇�씤�븳 �궗�슜�옄媛� 鍮꾪솢�꽦�씤吏� �솗�씤�븳�떎. + User user = this.webAppUtil.getLoginUserObject(); this.workspaceService.checkUseWorkspace(); if (issueForm.getRemoveIds().size() < 1) { @@ -1705,7 +2096,7 @@ List<Issue> removeIssues = Lists.newArrayList(); for (Long issueId : issueForm.getRemoveIds()) { - Issue issue = this.issueRemoves(issueId); + Issue issue = this.issueRemoves(issueId, user); removeIssues.add(issue); } @@ -1717,10 +2108,10 @@ log.info(ElasticSearchUtil.makeUserActiveHistoryMessage(this.webAppUtil.getLoginUser(), ElasticSearchConstants.ISSUE_REMOVE)); } - private Issue issueRemoves(Long issueId) { + private Issue issueRemoves(Long issueId, User user) { Issue issue = this.getIssue(issueId); // �씠�뒋 �닔�젙 沅뚰븳�쓣 媛뽮퀬 �엳�뒗吏� �솗�씤 - this.verifyIssueModifyPermission(issueId); + this.verifyIssueModifyPermission(issue, user); // �씠�뒋 泥⑤� �뙆�씪�쓣 �궘�젣�븳�떎. if (issue.getAttachedFiles().size() > 0) { @@ -1731,6 +2122,17 @@ } // 泥⑤��뙆�씪 �궘�젣 this.attachedFileService.removeAttachedFiles(attachedFileIds); + } + + // 吏��슱 �씠�뒋媛� �뿰愿��씠�뒋�씤吏� 泥댄겕 �썑 �뿰愿��씠�뒋 �뀒�씠釉붿뿉�꽌�룄 �궘�젣�븳�떎. + List<IssueRelation> issueRelationList = this.issueRelationRepository.findByRelationIssueId(issueId); + if (issueRelationList != null && issueRelationList.size() > 0) { + for(IssueRelation issueRelation : issueRelationList){ + StringBuilder sb = new StringBuilder(); + issueHistoryService.detectRelationIssue(IssueHistoryType.DELETE, issueRelation, sb); + issueHistoryService.addIssueHistory(issueRelation.getIssue(), IssueHistoryType.MODIFY, sb.toString()); + this.issueRelationRepository.delete(issueRelation); + } } // �씠�뒋 �깮�꽦, �궘�젣�떆 �삁�빟 �씠硫붿씪�뿉 �벑濡앺빐�넃�뒗�떎. @@ -1884,7 +2286,8 @@ issueCondition.setIssueIds(Lists.newArrayList()); // Map �뿉 �엳�뒗 �뜲�씠�꽣瑜� IssueVo �뜲�씠�꽣濡� 蹂��솚�븳�떎. - this.setMapToIssueVo(results, issueVos, issueCondition); + User user = this.webAppUtil.getLoginUserObject(); + this.setMapToIssueVo(results, issueVos, issueCondition, user); // IssueVos �뜲�씠�꽣瑜� �뿊���뿉�꽌 �몴�떆�븷 �닔 �엳�뒗 �뜲�씠�꽣濡� 蹂�寃쏀븳�떎. List<Map<String, String>> convertExcelViewToIssueMaps = this.convertExcelViewToIssueVos(issueVos); @@ -2052,10 +2455,12 @@ // �궗�슜�븯怨� �엳�뒗 �뾽臾� 怨듦컙�씠 �솢�꽦 �긽�깭�씤吏� �솗�씤�븳�떎. �궗�슜 怨듦컙�뿉�꽌 濡쒓렇�씤�븳 �궗�슜�옄媛� 鍮꾪솢�꽦�씤吏� �솗�씤�븳�떎. this.workspaceService.checkUseWorkspace(); + User user = this.webAppUtil.getLoginUserObject(); + for (Long issueId : issueForm.getIds()) { issueForm.setId(issueId); // �씠�뒋 �긽�깭 蹂�寃� - this.modifyIssueStatus(issueForm); + this.modifyIssueStatus(issueForm, user); } // �떞�떦 遺��꽌 �닔�젙 -- Gitblit v1.8.0